From: Chengguang Xu <cgxu519@mykernel.net>
To: "dsterba" <dsterba@suse.cz>
Cc: "clm" <clm@fb.com>, "josef" <josef@toxicpanda.com>,
"dsterba" <dsterba@suse.com>,
"linux-btrfs" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] btrfs: remove unnecessary hash_init()
Date: Tue, 08 Oct 2019 10:56:51 +0800 [thread overview]
Message-ID: <16da94c45a3.11fdf8eae27262.1375415460905873066@mykernel.net> (raw)
In-Reply-To: <20191007154452.GE2751@twin.jikos.cz>
---- 在 星期一, 2019-10-07 23:44:45 David Sterba <dsterba@suse.cz> 撰写 ----
> On Sat, Oct 05, 2019 at 01:17:34PM +0800, Chengguang Xu wrote:
> > hash_init() is not necessary in btrfs_props_init(),
> > so remove it.
>
> The part that explains why it's not necessary is missing in the
> changelo. And looking what hash_init and plain DEFINE_HASHTABLE does I
> don't think that removing hash_init is safe or making the code more
> clear.
Sorry for pool explanation in change log.
Look into the code, DEFINE_HASHTABLE has already included initialization code in it and
I think this is the main difference compare to DECLARE_HASHTABLE which still needs hash_init.
Thanks,
Chengguang
prev parent reply other threads:[~2019-10-08 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 5:17 [PATCH 1/3] btrfs: remove unnecessary hash_init() Chengguang Xu
2019-10-05 5:17 ` [PATCH 2/3] btrfs: code cleanup for compression type Chengguang Xu
2019-10-06 23:28 ` David Sterba
2019-10-07 13:47 ` Chengguang Xu
2019-10-05 5:17 ` [PATCH 3/3] btrfs: using enum to replace macro Chengguang Xu
2019-10-06 23:29 ` David Sterba
2019-10-07 15:44 ` [PATCH 1/3] btrfs: remove unnecessary hash_init() David Sterba
2019-10-08 2:56 ` Chengguang Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16da94c45a3.11fdf8eae27262.1375415460905873066@mykernel.net \
--to=cgxu519@mykernel.net \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).