From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan
Date: Tue, 22 Oct 2019 07:48:43 +0800 [thread overview]
Message-ID: <17f53bd1-10bf-9415-10dd-2724c48f5bea@oracle.com> (raw)
In-Reply-To: <20191021134346.GL3001@twin.jikos.cz>
On 10/21/19 9:43 PM, David Sterba wrote:
> On Tue, Oct 15, 2019 at 11:29:34AM +0800, Anand Jain wrote:
>> I was thinking there might be some common code between the
>> sub-commands in btrfs-progs now or in future, and if the printf()
>> due to verbose is required in one sub-command and the same printf()
>> due to verbose is not required in another sub-command (which I
>> called unwanted message) then we won't have any choice to not
>> to print those unwanted printf().
>> But as this is just an anticipatory only, so probably we could try
>> global verbose and see how it fares. I will try.
>
> I see, but it would be better to have a concrete example where it's
> problematic so we can figure out ways how to filter unwanted messages.
>
I solved with an argument to btrfs_scan_devcies() [1], by adding
%verbose argument to btrfs_scan_devices() to make sure
only btrfs dev scan would print the verbose and not the btrfs fi show.
If btrfs fi show prints the verbose it shall break few test-cases
in fstests.
[1]
https://patchwork.kernel.org/patch/11201791/
https://patchwork.kernel.org/patch/11201793/
prev parent reply other threads:[~2019-10-21 23:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 4:11 [PATCH v3] btrfs-progs: add verbose option to btrfs device scan Anand Jain
2019-10-02 4:44 ` [PATCH v3.1] " Anand Jain
2019-10-07 17:41 ` [PATCH v3] " David Sterba
2019-10-08 2:53 ` Anand Jain
2019-10-14 15:24 ` David Sterba
2019-10-15 3:29 ` Anand Jain
2019-10-21 13:43 ` David Sterba
2019-10-21 23:48 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f53bd1-10bf-9415-10dd-2724c48f5bea@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).