From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 5/8] btrfs-progs: Add btrfs_uuid_tree_remove
Date: Tue, 14 Sep 2021 17:22:49 +0800 [thread overview]
Message-ID: <1b4eb1fd-6770-746c-6b65-84ef12572652@gmx.com> (raw)
In-Reply-To: <20210914090558.79411-6-nborisov@suse.com>
On 2021/9/14 下午5:05, Nikolay Borisov wrote:
> It will be used to clear received data on RW snapshots that were
> received.
It would be more helpful to mention it's a backport of kernel function.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> kernel-shared/ctree.h | 3 ++
> kernel-shared/uuid-tree.c | 82 +++++++++++++++++++++++++++++++++++++++
> 2 files changed, 85 insertions(+)
>
> diff --git a/kernel-shared/ctree.h b/kernel-shared/ctree.h
> index 91a85796a678..158281a9fd67 100644
> --- a/kernel-shared/ctree.h
> +++ b/kernel-shared/ctree.h
> @@ -2860,6 +2860,9 @@ int btrfs_uuid_tree_add(struct btrfs_trans_handle *trans, u8 *uuid, u8 type,
> u64 subvol_id_cpu);
>
> int btrfs_is_empty_uuid(u8 *uuid);
> +int btrfs_uuid_tree_remove(struct btrfs_trans_handle *trans, u8 *uuid, u8 type,
> + u64 subid);
> +
>
> static inline int is_fstree(u64 rootid)
> {
> diff --git a/kernel-shared/uuid-tree.c b/kernel-shared/uuid-tree.c
> index 51a7b5d9ff5d..0f0fbf667dda 100644
> --- a/kernel-shared/uuid-tree.c
> +++ b/kernel-shared/uuid-tree.c
> @@ -120,3 +120,85 @@ int btrfs_is_empty_uuid(u8 *uuid)
> }
> return 1;
> }
> +
> +int btrfs_uuid_tree_remove(struct btrfs_trans_handle *trans, u8 *uuid, u8 type,
> + u64 subid)
> +{
> + struct btrfs_fs_info *fs_info = trans->fs_info;
> + struct btrfs_root *uuid_root = fs_info->uuid_root;
> + int ret;
> + struct btrfs_path *path = NULL;
> + struct btrfs_key key;
> + struct extent_buffer *eb;
> + int slot;
> + unsigned long offset;
> + u32 item_size;
> + unsigned long move_dst;
> + unsigned long move_src;
> + unsigned long move_len;
> +
> + if (!uuid_root) {
> + ret = -EINVAL;
> + goto out;
> + }
> +
> + btrfs_uuid_to_key(uuid, &key);
> + key.type = type;
> +
> + path = btrfs_alloc_path();
> + if (!path) {
> + ret = -ENOMEM;
> + goto out;
> + }
> +
> + ret = btrfs_search_slot(trans, uuid_root, &key, path, -1, 1);
> + if (ret < 0) {
> + warning("error %d while searching for uuid item!", ret);
> + goto out;
> + }
> + if (ret > 0) {
> + ret = -ENOENT;
> + goto out;
> + }
> +
> +
> + eb = path->nodes[0];
> + slot = path->slots[0];
> + offset = btrfs_item_ptr_offset(eb, slot);
> + item_size = btrfs_item_size_nr(eb, slot);
> + if (!IS_ALIGNED(item_size, sizeof(u64))) {
> + warning("uuid item with illegal size %lu!", (unsigned long)item_size);
> + ret = -ENOENT;
> + goto out;
> + }
> + while (item_size) {
> + __le64 read_subid;
> +
> + read_extent_buffer(eb, &read_subid, offset, sizeof(read_subid));
> + if (le64_to_cpu(read_subid) == subid)
> + break;
> + offset += sizeof(read_subid);
> + item_size -= sizeof(read_subid);
> + }
> +
> + if (!item_size) {
> + ret = -ENOENT;
> + goto out;
> + }
> +
> + item_size = btrfs_item_size_nr(eb, slot);
> + if (item_size == sizeof(subid)) {
> + ret = btrfs_del_item(trans, uuid_root, path);
> + goto out;
> + }
> +
> + move_dst = offset;
> + move_src = offset + sizeof(subid);
> + move_len = item_size - (move_src - btrfs_item_ptr_offset(eb, slot));
> + memmove_extent_buffer(eb, move_dst, move_src, move_len);
> + btrfs_truncate_item(path, item_size - sizeof(subid), 1);
> +
> +out:
> + btrfs_free_path(path);
> + return ret;
> +}
>
next prev parent reply other threads:[~2021-09-14 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 9:05 [PATCH v2 0/8] Implement progs support for removing received uuid on RW vols Nikolay Borisov
2021-09-14 9:05 ` [PATCH v2 1/8] btrfs-progs: Add btrfs_is_empty_uuid Nikolay Borisov
2021-09-16 7:26 ` Anand Jain
2021-09-20 11:41 ` David Sterba
2021-09-14 9:05 ` [PATCH v2 2/8] btrfs-progs: Remove root argument from btrfs_fixup_low_keys Nikolay Borisov
2021-09-14 9:05 ` [PATCH v2 3/8] btrfs-progs: Remove fs_info argument from leaf_data_end Nikolay Borisov
2021-09-14 9:05 ` [PATCH v2 4/8] btrfs-progs: Remove root argument from btrfs_truncate_item Nikolay Borisov
2021-09-14 9:05 ` [PATCH v2 5/8] btrfs-progs: Add btrfs_uuid_tree_remove Nikolay Borisov
2021-09-14 9:22 ` Qu Wenruo [this message]
2021-09-14 9:05 ` [PATCH v2 6/8] btrfs-progs: Implement helper to remove received information of RW subvol Nikolay Borisov
2021-09-14 9:23 ` Qu Wenruo
2021-09-14 9:05 ` [PATCH v2 7/8] btrfs-progs: check: Implement removing received data for RW subvols Nikolay Borisov
2021-09-14 9:25 ` Qu Wenruo
2021-09-14 9:55 ` Nikolay Borisov
2021-09-14 9:05 ` [PATCH v2 8/8] btrfs-progs: tests: Add test for received information removal Nikolay Borisov
2021-09-14 9:30 ` [PATCH v2 0/8] Implement progs support for removing received uuid on RW vols Qu Wenruo
2021-09-14 9:30 ` Qu Wenruo
2021-09-14 9:31 ` Nikolay Borisov
2021-09-21 18:51 ` David Sterba
2021-09-21 22:08 ` Graham Cobb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b4eb1fd-6770-746c-6b65-84ef12572652@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).