From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A94C433E1 for ; Mon, 24 Aug 2020 19:23:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33C2C20578 for ; Mon, 24 Aug 2020 19:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="rI9ZjW/b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgHXTXm (ORCPT ); Mon, 24 Aug 2020 15:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgHXTXd (ORCPT ); Mon, 24 Aug 2020 15:23:33 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09B2AC061575 for ; Mon, 24 Aug 2020 12:23:32 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id 144so8578548qkl.5 for ; Mon, 24 Aug 2020 12:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=VY8icQ/PEHeeVHFUx8sscyHaZUX7ephlQwZof8ngJKI=; b=rI9ZjW/b7AGEc5bqkJ9ZmPOdmUnyxtTG9TJ9EJDL0aoE8MU3nnygkHNkIzRqgncbEV LzjcHCAHh9KPLTfpk1YPKtdnE2gYK/iSw5qAtcUBNtn+NrQ3RJ8GjJRxtrrgN4zcVXeJ 2gz3sw3xTxlMbDmu57JSRkLAukLRXhT9+sGyTvNRZK9+oAldM5ThLMZ8RZXNltIZytdh bNW0guDDEqrpMVCr0j1xie78aXH7QkKqSg78M0I+bRx5zy3B6IcaBkVLZVHre87DC6bR WW9TKtpY1kxR87wxV8XnUo7iVmaswEmdVf+ItBzzLXt3lBcbnzRgHJvnY+6gwYR0EL2j frRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VY8icQ/PEHeeVHFUx8sscyHaZUX7ephlQwZof8ngJKI=; b=IUScsZQOF0TzLI1VTrFhfgnEDyIfFplXNBUdReVHtr33/9LiJJJ9Au9xoF2LlNWhXy Fb0oSmVpqlXK3GyNonDIDHWWnY1Dy7m4eS6LsKo90irSQ3w7DEuKIgtj3WfgqrVtdU78 za2JtkA8RTyuMUjnLosbQDgRczeU8LIJMWNkxfziaoDxfLKVzyfgHyKT4uNxOkO8aDjm rIbd0BihS7KER2xNDNxvbV+Z4x7LC/lDWZEk+k8N2wAobTVI6b8T5D6O1WKc28Yv8DXh zx4jQu4auX0kBvpvui5Bk50uRyKdbcQ/9sHMqVaO7FLwhTJL66iSYH16YsW8IcSIR3BA x2Rw== X-Gm-Message-State: AOAM5304HwTlygs2ilVE1ebvf4O9HibkjW3ENigGp7e9R3BS9A6IshBJ kexT3aJRinZvNW9vIJZJDKan4g== X-Google-Smtp-Source: ABdhPJw2tcITtQVNYTlOFW+NJfGITi55RnDhTWDgOriQTyXSpBz+Gg+QSmQaYNgBvlS7heoQz9wzcQ== X-Received: by 2002:a37:4e4d:: with SMTP id c74mr6012905qkb.311.1598297011691; Mon, 24 Aug 2020 12:23:31 -0700 (PDT) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id w17sm7206175qki.65.2020.08.24.12.23.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2020 12:23:31 -0700 (PDT) Subject: Re: [PATCH v5 5/9] btrfs: add ram_bytes and offset to btrfs_ordered_extent To: Omar Sandoval , linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Al Viro , Christoph Hellwig Cc: Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com References: <0a38de964b7f623b3cf25c334373cb10cab95b2d.1597993855.git.osandov@osandov.com> From: Josef Bacik Message-ID: <1b757e84-f700-e112-bb8c-d6e61bae1f6e@toxicpanda.com> Date: Mon, 24 Aug 2020 15:23:28 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <0a38de964b7f623b3cf25c334373cb10cab95b2d.1597993855.git.osandov@osandov.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 8/21/20 3:38 AM, Omar Sandoval wrote: > From: Omar Sandoval > > Currently, we only create ordered extents when ram_bytes == num_bytes > and offset == 0. However, RWF_ENCODED writes may create extents which > only refer to a subset of the full unencoded extent, so we need to plumb > these fields through the ordered extent infrastructure and pass them > down to insert_reserved_file_extent(). > > Since we're changing the btrfs_add_ordered_extent* signature, let's get > rid of the trivial wrappers and add a kernel-doc. > > Reviewed-by: Nikolay Borisov > Signed-off-by: Omar Sandoval Reviewed-by: Josef Bacik Thanks, Josef