Re: [PATCH v4 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead

[Qu Wenruo <quwenruo.btrfs@gmx.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1305 bytes --]



On 2019/1/23 上午12:28, David Sterba wrote:
> On Tue, Jan 15, 2019 at 04:15:57PM +0800, Qu Wenruo wrote:
>> This patchset can be fetched from github:
>> https://github.com/adam900710/linux/tree/qgroup_delayed_subtree
>>
>> Which is based on v5.0-rc1.
>>
>> This patch address the heavy load subtree scan, but delaying it until
>> we're going to modify the swapped tree block.
> 
> I'd like to merge this patchset, the overall logic is fine but I've
> found lots of coding style issues, too many to fix them just myself.
> 
>> v4:
>> - Renaming members from "file_*" to "subv_*".
>>   Members like "file_bytenr" is pretty confusing, renaming it to
>>   "subv_bytenr" avoid the confusion.
> 
> The naming change is incomplete, there are many more references to 'file
> tree' in comments and changelogs, the naming should be unified
> everywhere. Also I'd prefer to use 'subvol' though it's a bit longer
> than 'subv', the former seems to be the most common form.

I have to admit this 'subv' naming is completely my bad.

I tend to keep the naming as long as the original 'file' so no format
change is needed at all.
But it turns out that trick doesn't work at all.

I'll get rid of the bad behavior.

Thanks,
Qu

> 
> I'll comment the patches with the rest.
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]