linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <josef@redhat.com>
To: liubo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, Josef Bacik <josef@redhat.com>,
	jim owens <owens6336@gmail.com>,
	Chris Mason <chris.mason@oracle.com>,
	"Yan, Zheng" <zheng.yan@oracle.com>
Subject: Re: [PATCH] btrfs/direct-IO: fix a bug of btrfs_dio_read
Date: Wed, 5 May 2010 22:11:36 -0400	[thread overview]
Message-ID: <20100506021136.GB5672@localhost.localdomain> (raw)
In-Reply-To: <4BE2257A.7030005@cn.fujitsu.com>

On Thu, May 06, 2010 at 10:12:10AM +0800, liubo wrote:
> As I mentioned in the bug-report, when the file size is 
> not n * BUFFERSIZE, this file cannot be read correctly 
> and the system will crash or hang up.
> 
> After investigation, I fount that data_len should be 
> checked before lock_extent, in order to prevent the 
> situation that when it comes to the file end, 
> diocb->lockstart changes to lockend+1, then lock_extent
>  will cause system's crash or hang.
> 
> So move the data_len's check ahead.
> 

Please read my previous email, DIO has been refactored, this code isn't going to
be used anymore.  Thanks,

Josef

  reply	other threads:[~2010-05-06  2:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-06  2:12 [PATCH] btrfs/direct-IO: fix a bug of btrfs_dio_read liubo
2010-05-06  2:11 ` Josef Bacik [this message]
2010-05-06  2:24   ` liubo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100506021136.GB5672@localhost.localdomain \
    --to=josef@redhat.com \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=liubo2009@cn.fujitsu.com \
    --cc=owens6336@gmail.com \
    --cc=zheng.yan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).