From: Dan Carpenter <error27@gmail.com>
To: Johannes Hirte <johannes.hirte@fem.tu-ilmenau.de>
Cc: linux-btrfs@vger.kernel.org, Yan Zheng <zheng.yan@oracle.com>,
Josef Bacik <josef@redhat.com>, Christoph Hellwig <hch@lst.de>,
Chris Mason <chris.mason@oracle.com>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 11/11] btrfs: The file argument for fsync() is never null
Date: Mon, 14 Jun 2010 22:49:59 +0200 [thread overview]
Message-ID: <20100614204959.GA5483@bicker> (raw)
In-Reply-To: <201006142207.25930.johannes.hirte@fem.tu-ilmenau.de>
>
> addr2line showed me exact this change you made.
>
> It happend with a linux-2.6.34 with the latest btrfs-changes on top.
>
Yes. It used to be possible in 2.6.34 to get have file be null but in
2.6.35 it's not. Did you pull in 7ea8085910e: "drop unused dentry
argument to ->fsync"? That introduces a dereference at the start of the
function.
Sorry about this. I didn't take back porting into consideration.
regards,
dan carpenter
next prev parent reply other threads:[~2010-06-14 20:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 9:49 [patch 11/11] btrfs: The file argument for fsync() is never null Dan Carpenter
2010-06-14 20:07 ` Johannes Hirte
2010-06-14 20:49 ` Dan Carpenter [this message]
2010-06-14 20:58 ` Christoph Hellwig
2010-06-14 21:11 ` Dan Carpenter
2010-06-14 21:16 ` Christoph Hellwig
2010-06-14 21:45 ` Johannes Hirte
2010-06-15 0:08 ` Chris Mason
2010-06-16 18:04 ` Johannes Hirte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100614204959.GA5483@bicker \
--to=error27@gmail.com \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=johannes.hirte@fem.tu-ilmenau.de \
--cc=josef@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).