From: Hugo Mills <hugo-lkml@carfax.org.uk>
To: liubo <liubo2009@cn.fujitsu.com>
Cc: Hugo Mills <hugo-lkml@carfax.org.uk>, linux-btrfs@vger.kernel.org
Subject: Re: [patch 1/2] Balance progress monitoring (updated)
Date: Mon, 1 Nov 2010 12:55:10 +0000 [thread overview]
Message-ID: <20101101125510.GA4709@vlad.carfax.org.uk> (raw)
In-Reply-To: <4CCE751D.6030204@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1038 bytes --]
On Mon, Nov 01, 2010 at 04:06:53PM +0800, liubo wrote:
> On 10/30/2010 09:39 PM, Hugo Mills wrote:
> > This patch introduces a basic form of progress monitoring for balance
> > operations, by counting the number of block groups remaining. The
> > information is exposed to userspace by an ioctl.
> >
>
> IMO, tracking the information of blocks which are balancing also makes sense.
> For example, the block information's blocknr.
> It can help us monitor better.
I don't see how that will help. The block group IDs (which is all
that we get at this level) are effectively arbitrary 64-bit numbers,
and are what appear in the kernel logs. How could that information be
used to improve monitoring?
I'm not ruling out the idea completely -- I just can't see at the
moment how it would be used.
Hugo.
--
=== Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk ===
PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk
--- Is a diversity twice as good as a university? ---
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2010-11-01 12:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 0:07 [patch 0/2] Control filesystem balances (kernel side) Hugo Mills
2010-10-30 0:07 ` [patch 1/2] Balance progress monitoring Hugo Mills
2010-10-30 13:37 ` Hugo Mills
2010-10-30 13:39 ` [patch 1/2] Balance progress monitoring (updated) Hugo Mills
2010-11-01 8:06 ` liubo
2010-11-01 12:55 ` Hugo Mills [this message]
2010-11-02 0:51 ` liubo
2010-10-30 0:07 ` [patch 2/2] Cancel filesystem balance Hugo Mills
2010-10-30 17:44 ` [patch 0/2] Control filesystem balances (kernel side) Goffredo Baroncelli
2010-11-01 12:58 ` Xavier Nicollet
2010-11-01 12:52 ` Tomasz Torcz
2010-11-01 13:05 ` Hugo Mills
2010-11-04 22:55 ` RFC: exporting info via sysfs [was Re: [patch 0/2] Control filesystem balances (kernel side)] Goffredo Baroncelli
2010-11-05 12:41 ` Hugo Mills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101125510.GA4709@vlad.carfax.org.uk \
--to=hugo-lkml@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).