linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Disseldorp <ddiss@suse.de>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner
Date: Fri, 23 May 2014 11:39:36 +0200	[thread overview]
Message-ID: <20140523113936.6dace4f7@f163.suse.de> (raw)
In-Reply-To: <1400817931-32326-1-git-send-email-fdmanana@gmail.com>

On Fri, 23 May 2014 05:05:30 +0100, Filipe David Borba Manana wrote:

> So that the same check (btrfs cloner program presence) can be reused
> by other tests.
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
> ---
>  common/rc       | 7 +++++++
>  tests/btrfs/035 | 4 +---
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index d1788d1..f27ee53 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2085,6 +2085,13 @@ _require_fssum()
>  	[ -x $FSSUM_PROG ] || _notrun "fssum not built"
>  }
>  
> +_require_btrfs_cloner()
> +{
> +	CLONER_PROG=$here/src/cloner
> +	[ -x $CLONER_PROG ] || \
> +		_notrun "cloner binary not present at $CLONER_PROG"
> +}

Would prefer to avoid the reliance on $here, but it appears that other
common/rc functions make the same assumption.

Reviewed-by: David Disseldorp <ddiss@suse.de>

Cheers, David

      parent reply	other threads:[~2014-05-23  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23  4:05 [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner Filipe David Borba Manana
2014-05-23  4:05 ` [PATCH 2/2] xfstests: add test for btrfs ioctl clone operation Filipe David Borba Manana
2014-05-23  9:44   ` David Disseldorp
2014-05-23 13:19   ` [PATCH 2/2 v2] " Filipe David Borba Manana
2014-05-24 16:50   ` [PATCH 2/2 v3] " Filipe David Borba Manana
2014-05-26 15:48     ` David Disseldorp
2014-05-23  9:39 ` David Disseldorp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140523113936.6dace4f7@f163.suse.de \
    --to=ddiss@suse.de \
    --cc=fdmanana@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).