From: David Sterba <dsterba@suse.cz>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: provide better error message for raid profile mismatch
Date: Wed, 28 May 2014 18:53:33 +0200 [thread overview]
Message-ID: <20140528165333.GQ5346@twin.jikos.cz> (raw)
In-Reply-To: <5375CA68.4090808@jp.fujitsu.com>
On Fri, May 16, 2014 at 05:20:56PM +0900, Hidetoshi Seto wrote:
> Current error messages are like following:
> Error: unable to create FS with metadata profile 32 (have 2 devices)
> Error: unable to create FS with metadata profile 256 (have 2 devices)
>
> Obviously it is hard for users to interpret "profile XX" to proper
> meaning, such as "raidN". So use recongizable string instead of
> internal numerical value. In case of "dup", use an explicit message.
>
> Plus this patch fix a bug that message mistake metadata profile
> for data profile.
>
> After applying this patch, messages will be like:
> Error: dup is not allowed when FS have multiple devices
> Error: unable to create FS with metadata profile RAID6 (have 2
> devices but 3 devices are required)
Nice, thanks.
Moving the group_profile_* functions to utils.c was done in "Enhance
the command btrfs filesystem df", so your patch ends up a bit shorter.
I've modified the 'dup' to be 'DUP' in the error message and changelog
so it's consistent with spelling of the RAIDx names.
prev parent reply other threads:[~2014-05-28 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 8:20 [PATCH] btrfs-progs: provide better error message for raid profile mismatch Hidetoshi Seto
2014-05-28 16:53 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528165333.GQ5346@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).