From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, Karel Zak <kzak@redhat.com>
Subject: Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.
Date: Thu, 29 May 2014 14:43:08 +0200 [thread overview]
Message-ID: <20140529124308.GA29992@twin.jikos.cz> (raw)
In-Reply-To: <1397638952-16691-1-git-send-email-quwenruo@cn.fujitsu.com>
On Wed, Apr 16, 2014 at 05:02:32PM +0800, Qu Wenruo wrote:
> @@ -1704,10 +1720,14 @@ int btrfs_rm_device(struct btrfs_root *root, char *device_path)
>
> ret = 0;
>
> - /* Notify udev that device has changed */
> - if (bdev)
> + if (bdev) {
> + /* Notify udev that device has changed */
> btrfs_kobject_uevent(bdev, KOBJ_CHANGE);
>
> + /* Update ctime/mtime for device path for libblkid */
> + update_dev_time(device_path);
The change on the device comes after the uevent notification, is it
possible that the event is delivered and processed before the device
times are updated? I would say so.
> + }
> +
> error_brelse:
> brelse(bh);
> if (bdev)
next prev parent reply other threads:[~2014-05-29 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 9:02 [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove Qu Wenruo
2014-05-29 12:43 ` David Sterba [this message]
2014-05-30 1:27 ` Qu Wenruo
2014-06-04 5:51 ` Qu Wenruo
2014-05-30 7:51 ` Anand Jain
2014-05-30 7:53 ` Anand Jain
2014-05-30 8:43 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140529124308.GA29992@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=kzak@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).