From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:48155 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756143AbaE2Oty (ORCPT ); Thu, 29 May 2014 10:49:54 -0400 Date: Thu, 29 May 2014 16:49:51 +0200 From: David Sterba To: Anand Jain Cc: linux-btrfs@vger.kernel.org, jeffm@suse.com, dsterba@suse.cz, clm@fb.com Subject: Re: [PATCH 2/4] btrfs: dev add should add its sysfs entry Message-ID: <20140529144951.GE29992@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <1401096626-13210-1-git-send-email-anand.jain@oracle.com> <1401096626-13210-3-git-send-email-anand.jain@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1401096626-13210-3-git-send-email-anand.jain@oracle.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon, May 26, 2014 at 05:30:24PM +0800, Anand Jain wrote: > From: Anand Jain > > we would need the device links to be created, > when device is added. Looks good (plus the btrfs_ prefix mentioned before). Reviewed-by: David Sterba I was comparing it to Jeff's patch and I think Anand's version is cleaner because it uses helpers that conveniently wrap the bdev/part_to_dev trickery. There's one difference in btrfs_init_new_device, where the add_membership is called, but both locations look correct to me.