From: David Sterba <dsterba@suse.cz>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org, jeffm@suse.com, clm@fb.com
Subject: Re: [PATCH 4/4] btrfs: create sprout should rename fsid on the sysfs as well
Date: Mon, 2 Jun 2014 17:39:44 +0200 [thread overview]
Message-ID: <20140602153944.GB22324@twin.jikos.cz> (raw)
In-Reply-To: <538C343C.20308@oracle.com>
On Mon, Jun 02, 2014 at 04:22:20PM +0800, Anand Jain wrote:
> >>--- a/fs/btrfs/volumes.c
> >>+++ b/fs/btrfs/volumes.c
> >>@@ -2084,6 +2084,7 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path)
> >> mutex_unlock(&root->fs_info->fs_devices->device_list_mutex);
> >>
> >> if (seeding_dev) {
> >>+ char fsid_buf[37];
> >
> >Is there a symbolic constant available? We have one in userspace, but I
> >can't find one for kernel, only a few locally defined.
>
> now defined the same (as in progs) in kernel as well.
In progs it's in utils.h
40 #define BTRFS_UUID_UNPARSED_SIZE 37
but I don't see where it's defined in kernel. Can you please give me a
pointer?
On the other hand, progs have a local define, we can do the same, I
don't see any other potential users.
next prev parent reply other threads:[~2014-06-02 15:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 9:30 [PATCH 0/4] update sysfs per btrfs device operations Anand Jain
2014-05-26 9:30 ` [PATCH 1/4] btrfs: dev delete should remove sysfs entry Anand Jain
2014-05-29 13:04 ` David Sterba
2014-05-30 6:10 ` Anand Jain
2014-05-30 14:10 ` David Sterba
2014-05-26 9:30 ` [PATCH 2/4] btrfs: dev add should add its " Anand Jain
2014-05-29 14:49 ` David Sterba
2014-05-26 9:30 ` [PATCH 3/4] btrfs: dev replace should replace the " Anand Jain
2014-05-29 13:29 ` David Sterba
2014-05-30 7:40 ` Anand Jain
2014-06-03 3:47 ` Anand Jain
2014-06-03 13:39 ` David Sterba
2014-05-26 9:30 ` [PATCH 4/4] btrfs: create sprout should rename fsid on the sysfs as well Anand Jain
2014-05-29 12:54 ` David Sterba
2014-06-02 8:22 ` Anand Jain
2014-06-02 15:39 ` David Sterba [this message]
2014-06-03 0:27 ` Anand Jain
2014-05-28 8:30 ` [PATCH RFC v2] btrfs: revamp /sys/fs/btrfs/<fsid>/devices Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140602153944.GB22324@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Anand.Jain@oracle.com \
--cc=clm@fb.com \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).