From: David Sterba <dsterba@suse.cz>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Wang Shilong <wangsl.fnst@cn.fujitsu.com>,
Anand Jain <anand.jain@oracle.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.cz, sandeen@redhat.com,
rm@romanrm.net, koen@dominion.thruhere.net
Subject: Re: [PATCH v6] btrfs: label should not contain return char
Date: Tue, 1 Jul 2014 17:05:29 +0200 [thread overview]
Message-ID: <20140701150529.GK1553@twin.jikos.cz> (raw)
In-Reply-To: <53B26A87.4080800@jp.fujitsu.com>
On Tue, Jul 01, 2014 at 05:00:07PM +0900, Satoru Takeuchi wrote:
> --- a/fs/btrfs/sysfs.c
> +++ b/fs/btrfs/sysfs.c
> @@ -363,7 +363,8 @@ static ssize_t btrfs_label_show(struct kobject *kobj,
> struct kobj_attribute *a, char *buf)
> {
> struct btrfs_fs_info *fs_info = to_fs_info(kobj);
> - return snprintf(buf, PAGE_SIZE, "%s\n", fs_info->super_copy->label);
> + char *label = fs_info->super_copy->label;
> + return snprintf(buf, PAGE_SIZE, label[0] ? "%s\n" : "%s", label);
I'd prefer "" instead of the "%s" branch, but does not matter that much,
Reviewed-by: David Sterba <dsterba@suse.cz>
prev parent reply other threads:[~2014-07-01 15:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 17:04 [PATCH 1/2] btrfs: label should not contain return char Anand Jain
2014-05-19 17:04 ` [PATCH 2/2] btrfs: usage error should not be logged into system log Anand Jain
2014-05-20 6:38 ` [PATCH 2/2 v2] " Anand Jain
2014-05-20 16:36 ` David Sterba
2014-05-19 17:16 ` [PATCH 1/2] btrfs: label should not contain return char Eric Sandeen
2014-05-20 6:40 ` Anand Jain
2014-05-19 17:19 ` Roman Mamedov
2014-05-20 6:42 ` Anand Jain
2014-05-20 6:36 ` [PATCH 1/2 v2] " Anand Jain
2014-05-20 16:32 ` Eric Sandeen
2014-05-22 2:05 ` Anand Jain
2014-05-22 2:14 ` Eric Sandeen
2014-05-22 4:14 ` Roman Mamedov
2014-05-22 16:06 ` Eric Sandeen
2014-05-20 16:33 ` David Sterba
2014-05-20 16:41 ` Eric Sandeen
2014-05-22 10:47 ` Anand Jain
2014-05-22 10:41 ` [PATCH 1/2 v3] " Anand Jain
2014-05-22 10:41 ` [PATCH 2/2 v3] btrfs: usage error should not be logged into system log Anand Jain
2014-05-22 11:21 ` Koen Kooi
2014-05-23 2:41 ` Anand Jain
2014-05-22 11:41 ` [PATCH 1/2 v3] btrfs: label should not contain return char David Sterba
2014-05-23 2:50 ` [PATCH 1/2 v4] " Anand Jain
2014-05-23 2:50 ` [PATCH 2/2 v4] btrfs: usage error should not be logged into system log Anand Jain
2014-05-26 17:41 ` [PATCH 1/2 v4] btrfs: label should not contain return char David Sterba
2014-07-01 5:22 ` [PATCH v5] " Satoru Takeuchi
2014-07-01 6:46 ` Wang Shilong
2014-07-01 8:00 ` [PATCH v6] " Satoru Takeuchi
2014-07-01 8:29 ` Wang Shilong
2014-07-01 15:05 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701150529.GK1553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=rm@romanrm.net \
--cc=sandeen@redhat.com \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).