From: David Sterba <dsterba@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: remove pointless debugfs interface
Date: Thu, 1 Sep 2016 14:15:23 +0200 [thread overview]
Message-ID: <20160901121523.GM16983@suse.cz> (raw)
In-Reply-To: <d3e6540b-903d-4d35-e7b0-07a41f1feec5@redhat.com>
On Wed, Aug 31, 2016 at 04:38:16PM -0500, Eric Sandeen wrote:
> On 8/31/16 2:08 PM, David Sterba wrote:
> > On Wed, Aug 31, 2016 at 10:13:49AM -0500, Eric Sandeen wrote:
> >> A /sys/kernel/debug/btrfs/test file was added nearly
> >> two and a half years ago, but it serves no purpose;
> >
> > It does. Introduced in 1bae30982bc86ab66d61ccb6e22792593b45d44d says
> > something about helping developers to easily export information from the
> > filesystem, to aid debugging. Writing the debugfs support code is not
> > obviously trivial, so it's idling in the source. Exporing a new value is
> > as easy as copy and update 3 lines of code. If you have no use for it,
> > fine.
>
> I had thought that Documentation/filesystems/debugfs.txt would suffice,
> but if you keep stuff lying around in btrfs just in case somebody needs
> to export a global variable in the future, I suppose that's cool too. ;)
How much time would you spend coding it? I guess more than a couple of
minutes, possibly more than once. And not in the middle of debugging
something else. There are more examples of code that has no apparent
user but is used for debugging.
next prev parent reply other threads:[~2016-09-01 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:13 [PATCH] btrfs: remove pointless debugfs interface Eric Sandeen
2016-08-31 19:08 ` David Sterba
2016-08-31 21:38 ` Eric Sandeen
2016-09-01 12:15 ` David Sterba [this message]
2016-08-31 22:36 ` Jeff Mahoney
2016-09-01 12:22 ` David Sterba
2016-08-31 21:49 ` [PATCH V2] btrfs: fix perms on demonstration " Eric Sandeen
2016-09-01 12:22 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901121523.GM16983@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).