linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 03/11] btrfs-progs: qgroup-verify: Use fs_info->readonly to check if we should repair qgroups
Date: Tue,  7 Aug 2018 16:19:30 +0800	[thread overview]
Message-ID: <20180807081938.21348-4-wqu@suse.com> (raw)
In-Reply-To: <20180807081938.21348-1-wqu@suse.com>

In fact qgroup-verify is just kind of offline qgroup rescan, and later
mkfs qgroup support will reuse it.

So qgroup-verify doesn't really need to rely the global variable @repair
to check if it should repair qgroups.

Instead check fs_info->readonly to do the repair.

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 qgroup-verify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qgroup-verify.c b/qgroup-verify.c
index 4b8bfa69914d..eb42e199bcf9 100644
--- a/qgroup-verify.c
+++ b/qgroup-verify.c
@@ -1617,7 +1617,7 @@ int repair_qgroups(struct btrfs_fs_info *info, int *repaired)
 
 	*repaired = 0;
 
-	if (!repair)
+	if (info->readonly)
 		return 0;
 
 	list_for_each_entry_safe(count, tmpcount, &bad_qgroups, bad_list) {
-- 
2.18.0


  parent reply	other threads:[~2018-08-07 10:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07  8:19 [PATCH v3 00/11] btrfs-progs: mkfs: Quota support through -Q|--quota Qu Wenruo
2018-08-07  8:19 ` [PATCH 01/11] btrfs-progs: qgroup-verify: Avoid NULL pointer dereference for later silent qgroup repair Qu Wenruo
2018-08-07  8:19 ` [PATCH 02/11] btrfs-progs: qgroup-verify: Also repair qgroup status version Qu Wenruo
2018-08-07  8:19 ` Qu Wenruo [this message]
2018-08-07  8:19 ` [PATCH 04/11] btrfs-progs: qgroup-verify: Move qgroup classification out of report_qgroups Qu Wenruo
2018-08-07  8:19 ` [PATCH 05/11] btrfs-progs: qgroup-verify: Allow repair_qgroups function to do silent repair Qu Wenruo
2018-08-07  8:19 ` [PATCH 06/11] btrfs-progs: ctree: Introduce function to create an empty tree Qu Wenruo
2018-08-07  8:19 ` [PATCH 07/11] btrfs-progs: mkfs: Introduce function to insert qgroup info and limit items Qu Wenruo
2018-08-07  8:19 ` [PATCH 08/11] btrfs-progs: mkfs: Introduce function to setup quota root and rescan Qu Wenruo
2018-08-07  8:19 ` [PATCH 09/11] btrfs-progs: mkfs: Introduce mkfs time quota support Qu Wenruo
2018-08-07  8:19 ` [PATCH 10/11] btrfs-progs: test/mkfs: Add test case for -Q|--quota option Qu Wenruo
2018-08-07  8:19 ` [PATCH 11/11] btrfs-progs: test/mkfs: Add test case for --rootdir and --quota Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807081938.21348-4-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).