From: David Sterba <dsterba@suse.cz>
To: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>,
Qu Wenruo <quwenruo.btrfs@gmx.com>
Subject: Re: [PATCH v5] btrfs: qgroup: Remove qgroup items along with subvolume deletion
Date: Wed, 15 Aug 2018 15:06:05 +0200 [thread overview]
Message-ID: <20180815130605.GO24025@twin.jikos.cz> (raw)
In-Reply-To: <1b5d9d72-5e6b-a88b-0192-8676a19b9732@jp.fujitsu.com>
On Thu, Aug 09, 2018 at 04:05:36PM +0900, Misono Tomohiro wrote:
> When qgroup is on, subvolume deletion does not remove qgroup items
> of the subvolume (qgroup info, limit, relation) from quota tree and
> they need to get removed manually by "btrfs qgroup destroy".
>
> Since level 0 qgroup cannot be used/inherited by any other subvolume,
> let's remove them automatically when subvolume is deleted
> (to be precise, when the subvolume root is dropped).
Please note that dropping the 0-level qgroup has user-visible impact
that needs to be evaluated. I don't see anything like that in the
changelog. If there's a potential or actual breakage after this patch,
it needs to be addressed in some way.
This is not the first time somebody proposes to do the auto deletion.
While I'm not against it, it still has to be done the right way.
Anything that touches user interfaces must get extra care, and review
bandwidth for that is unfortunatelly extra low. I can't give you an ETA
or merge target for this patch.
next prev parent reply other threads:[~2018-08-15 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1533783766.git.misono.tomohiro@jp.fujitsu.com>
2018-08-09 4:12 ` [PATCH v4] btrfs: qgroup: Remove qgroup items along with subvolume deletion Misono Tomohiro
2018-08-09 5:47 ` Qu Wenruo
2018-08-09 6:05 ` Misono Tomohiro
2018-08-09 6:14 ` Qu Wenruo
2018-08-09 7:02 ` Misono Tomohiro
2018-08-09 7:05 ` [PATCH v5] " Misono Tomohiro
2018-08-15 13:06 ` David Sterba [this message]
2018-08-15 14:22 ` Qu Wenruo
2018-08-15 14:33 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815130605.GO24025@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).