From: Josef Bacik <josef@toxicpanda.com>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 1/4] btrfs: Introduce find_free_extent_ctl structure for later rework
Date: Fri, 12 Oct 2018 09:52:49 -0400 [thread overview]
Message-ID: <20181012135248.ll72gqjqe4yuxlxv@destiny> (raw)
In-Reply-To: <20181012061819.19482-2-wqu@suse.com>
On Fri, Oct 12, 2018 at 02:18:16PM +0800, Qu Wenruo wrote:
> Instead of tons of different local variables in find_free_extent(),
> extract them into find_free_extent_ctl structure, and add better
> explanation for them.
>
> Some modification may looks redundant, but will later greatly simplify
> function parameter list during find_free_extent() refactor.
>
> Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Thanks,
Josef
next prev parent reply other threads:[~2018-10-12 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 6:18 [PATCH v3 0/4] btrfs: Refactor find_free_extent() Qu Wenruo
2018-10-12 6:18 ` [PATCH v3 1/4] btrfs: Introduce find_free_extent_ctl structure for later rework Qu Wenruo
2018-10-12 8:25 ` Su Yue
2018-10-12 13:52 ` Josef Bacik [this message]
2018-10-12 6:18 ` [PATCH v3 2/4] btrfs: Refactor clustered extent allocation into find_free_extent_clustered() Qu Wenruo
2018-10-12 13:53 ` Josef Bacik
2018-10-12 6:18 ` [PATCH v3 3/4] btrfs: Refactor unclustered extent allocation into find_free_extent_unclustered() Qu Wenruo
2018-10-12 13:53 ` Josef Bacik
2018-10-12 6:18 ` [PATCH v3 4/4] btrfs: Refactor find_free_extent() loops update into find_free_extent_update_loop() Qu Wenruo
2018-10-12 13:52 ` Josef Bacik
2018-10-12 13:54 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012135248.ll72gqjqe4yuxlxv@destiny \
--to=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).