From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] btrfs: remove set but not used variable err in btrfs_add_link
Date: Mon, 19 Nov 2018 15:13:23 +0100 [thread overview]
Message-ID: <20181119141323.GC24115@twin.jikos.cz> (raw)
In-Reply-To: <20181119093817.9291-3-jthumshirn@suse.de>
On Mon, Nov 19, 2018 at 10:38:14AM +0100, Johannes Thumshirn wrote:
> err holds the return value of either btrfs_del_root_ref() or
> btrfs_del_inode_ref() but it hasn't been checked since it's introduction with
> commit fe66a05a0679 (Btrfs: improve error handling for btrfs_insert_dir_item
> callers) in 2012.
>
> As the error value hasn't been of any interest for 6 years we can just drop it
> as well.
No, I think there should actually be proper error hanling. This is on
the error handling path already so this might be tricky and could
require restructuring btrfs_add_link.
The error handling is not done everywhere it should and such
inconsistencies are more like a hint to improve that than to count the
years of negligence. Code removal patches should come with a brief
analysis why the code can be safely dropped. You did that, which is
great, but the conclusion was wrong.
next prev parent reply other threads:[~2018-11-19 14:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 9:38 [PATCH v2 0/5] btrfs: fix compiler warning with make W=1 Johannes Thumshirn
2018-11-19 9:38 ` [PATCH v2 1/5] btrfs: remove unused drop_on_err in btrfs_mkdir() Johannes Thumshirn
2018-11-19 9:38 ` [PATCH v2 2/5] btrfs: remove set but not used variable err in btrfs_add_link Johannes Thumshirn
2018-11-19 14:13 ` David Sterba [this message]
2018-11-19 9:38 ` [PATCH v2 3/5] btrfs: remove unused function btrfs_sysfs_feature_update() Johannes Thumshirn
2018-11-19 14:21 ` David Sterba
2018-11-19 9:38 ` [PATCH v2 4/5] btrfs: introduce EXPORT_FOR_TESTS macro Johannes Thumshirn
2018-11-19 9:49 ` Nikolay Borisov
2018-11-19 9:38 ` [PATCH v2 5/5] btrfs: use EXPORT_FOR_TESTS for conditionally shared functions Johannes Thumshirn
2018-11-19 9:50 ` Nikolay Borisov
2018-11-19 14:40 ` [PATCH v2 0/5] btrfs: fix compiler warning with make W=1 David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119141323.GC24115@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).