From: Su Yue <suy.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <suy.fnst@cn.fujitsu.com>
Subject: [RFC PATCH 08/17] btrfs: priority alloc: add btrfs_update_block_group_priority()
Date: Wed, 28 Nov 2018 11:11:39 +0800 [thread overview]
Message-ID: <20181128031148.357-9-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20181128031148.357-1-suy.fnst@cn.fujitsu.com>
Introduce btrfs_update_block_group_priority() to update
block_groups::priority. It will move block group from old tree
to new tree if need.
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
fs/btrfs/extent-tree.c | 76 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 76 insertions(+)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index b559c9a9afc6..5ea1f2e40701 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -11466,3 +11466,79 @@ void btrfs_remove_block_group_priority(struct btrfs_block_group_cache *cache)
spin_unlock(&cache->lock);
up_write(&pt->groups_sem);
}
+
+static inline struct btrfs_priority_tree *
+find_priority_tree(struct btrfs_space_info *sinfo, u64 flags, int level)
+{
+ int index = btrfs_bg_flags_to_raid_index(flags);
+
+ return search_priority_tree(&sinfo->priority_trees[index], level);
+}
+
+void btrfs_update_block_group_priority(struct btrfs_block_group_cache *cache)
+{
+ struct btrfs_priority_tree *old_tree, *new_tree;
+ struct rw_semaphore *front_sem, *back_sem;
+ long priority;
+ int old_level, new_level;
+
+ if (!is_priority_alloc_enabled(cache->fs_info))
+ return;
+
+ spin_lock(&cache->lock);
+ if (cache->priority != PRIORITY_BG_UPDATING) {
+ spin_unlock(&cache->lock);
+ return;
+ }
+
+ old_level = cache->priority_tree->level;
+ priority = compute_block_group_priority(cache);
+ new_level = compute_priority_level(cache->fs_info, priority);
+
+ /* no need to move the block group */
+ if (old_level == new_level) {
+ cache->priority = priority;
+ spin_unlock(&cache->lock);
+ return;
+ }
+ spin_unlock(&cache->lock);
+
+ old_tree = cache->priority_tree;
+ new_tree = find_priority_tree(cache->space_info, cache->flags,
+ new_level);
+
+ if (!old_tree || !new_tree) {
+ btrfs_err(cache->fs_info,
+"can't found priority tree %d for block_group %llu old level %d new priority %ld",
+ old_tree ? new_level : old_level,
+ cache->key.objectid, old_level, priority);
+ BUG();
+ }
+
+ if (old_level > new_level) {
+ front_sem = &old_tree->groups_sem;
+ back_sem = &new_tree->groups_sem;
+ } else {
+ front_sem = &new_tree->groups_sem;
+ back_sem = &old_tree->groups_sem;
+ }
+
+ down_write(front_sem);
+ down_write(back_sem);
+ spin_lock(&cache->lock);
+
+ /* the block group was removed/is removing */
+ if (cache->priority != PRIORITY_BG_UPDATING ||
+ priority != compute_block_group_priority(cache) ||
+ old_tree != cache->priority_tree)
+ goto out;
+
+ unlink_block_group_priority(old_tree, cache);
+ cache->priority = priority;
+ link_block_group_priority(new_tree, cache);
+ cache->priority_tree = new_tree;
+out:
+ spin_unlock(&cache->lock);
+ up_write(front_sem);
+ up_write(back_sem);
+}
--
2.19.1
next prev parent reply other threads:[~2018-11-28 3:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 3:11 [RFC PATCH 00/17] btrfs: implementation of priority aware allocator Su Yue
2018-11-28 3:11 ` [RFC PATCH 01/17] btrfs: priority alloc: prepare " Su Yue
2018-11-28 8:24 ` Nikolay Borisov
2018-11-28 9:24 ` Su Yue
2018-11-28 3:11 ` [RFC PATCH 02/17] btrfs: add mount definition BTRFS_MOUNT_PRIORITY_USAGE Su Yue
2018-11-28 3:11 ` [RFC PATCH 03/17] btrfs: priority alloc: introduce compute_block_group_priority/usage Su Yue
2018-11-28 8:56 ` Nikolay Borisov
2018-11-28 3:11 ` [RFC PATCH 04/17] btrfs: priority alloc: add functions to create/remove priority trees Su Yue
2018-11-28 3:11 ` [RFC PATCH 05/17] btrfs: priority alloc: introduce functions to add block group to priority tree Su Yue
2018-11-28 3:11 ` [RFC PATCH 06/17] btrfs: priority alloc: introduce three macros to mark block group status Su Yue
2018-11-28 3:11 ` [RFC PATCH 07/17] btrfs: priority alloc: add functions to remove block group from priority tree Su Yue
2018-11-28 3:11 ` Su Yue [this message]
2018-11-28 3:11 ` [RFC PATCH 09/17] btrfs: priority alloc: call create/remove_priority_trees in space_info Su Yue
2018-11-28 3:11 ` [RFC PATCH 10/17] btrfs: priority alloc: call add_block_group_priority while reading or making block group Su Yue
2018-11-28 3:11 ` [RFC PATCH 11/17] btrfs: priority alloc: remove block group from priority tree while removing " Su Yue
2018-11-28 3:11 ` [RFC PATCH 12/17] btrfs: priority alloc: introduce find_free_extent_search() Su Yue
2018-11-28 3:11 ` [RFC PATCH 13/17] btrfs: priority alloc: modify find_free_extent() to fit priority allocator Su Yue
2018-11-28 3:11 ` [RFC PATCH 14/17] btrfs: priority alloc: introduce btrfs_set_bg_updating and call btrfs_update_block_group_prioriy Su Yue
2018-11-28 3:11 ` [RFC PATCH 15/17] btrfs: priority alloc: write bg->priority_groups_sem while waiting reservation Su Yue
2018-11-28 3:11 ` [RFC PATCH 16/17] btrfs: priority alloc: write bg->priority_tree->groups_sem to avoid race in btrfs_delete_unused_bgs() Su Yue
2018-11-28 3:11 ` [RFC PATCH 17/17] btrfs: add mount option "priority_alloc=%s" Su Yue
2018-11-28 4:04 ` [RFC PATCH 00/17] btrfs: implementation of priority aware allocator Qu Wenruo
2018-12-02 5:28 ` Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128031148.357-9-suy.fnst@cn.fujitsu.com \
--to=suy.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).