From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead
Date: Wed, 12 Dec 2018 14:50:02 +0100 [thread overview]
Message-ID: <20181212135001.GW23615@twin.jikos.cz> (raw)
In-Reply-To: <fde0326c-0590-eb4e-4f61-250b7e202c05@gmx.com>
On Wed, Dec 12, 2018 at 09:20:33PM +0800, Qu Wenruo wrote:
>
>
> On 2018/12/12 下午8:37, David Sterba wrote:
> > On Wed, Dec 12, 2018 at 08:39:46AM +0800, Qu Wenruo wrote:
> >> changelog:
> >> v2:
> >> - Rebase to v4.20-rc1.
> >> - Instead commit transaction after each reloc tree merge, delay it until
> >> merge_reloc_roots() finishes.
> >> - This provides a more natural behavior, and reduce the unnecessary
> >> transaction commits.
> >> v3:
> >> - Fix backref walk deadlock by not triggering it at all.
> >> This also removes the need for @exec_post refactor and replace the
> >> patch to allow @old_root unpopulated.
> >> - Include the patch that fixes the unexpected data rsv free.
> >
> > I've tested the deadlock fix but it still locks up and there are some
> > lockdep warnings. I can't spend more time on that given the pre-merge
> > window timing so I'm going to postpone all qgruop things until the next
> > cycle.
>
> No problem.
>
> But would you please provide the reproducer?
> My test script can't reproduce lockup this time.
git://github.com/kdave/testunion
in the directory test-subvol-qg, it needs a 15GB tarred dump of
wikipedia, the url is in the repo. You can possibly replace it with
something else, the scripts need tmux and maybe some other utilites. Run
with startme script and path to fresh filesystem.
next prev parent reply other threads:[~2018-12-12 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 0:39 [PATCH v3 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 1/7] btrfs: qgroup: Move reserved data account from btrfs_delayed_ref_head to btrfs_qgroup_extent_record Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 2/7] btrfs: qgroup: Don't trigger backref walk at delayed ref insert time Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 3/7] btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots() Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 4/7] btrfs: qgroup: Refactor btrfs_qgroup_trace_subtree_swap() Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 5/7] btrfs: qgroup: Introduce per-root swapped blocks infrastructure Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 6/7] btrfs: qgroup: Use delayed subtree rescan for balance Qu Wenruo
2018-12-12 0:39 ` [PATCH v3 7/7] btrfs: qgroup: Cleanup old subtree swap code Qu Wenruo
2018-12-12 12:37 ` [PATCH v3 0/7] btrfs: qgroup: Delay subtree scan to reduce overhead David Sterba
2018-12-12 13:20 ` Qu Wenruo
2018-12-12 13:50 ` David Sterba [this message]
2018-12-12 13:53 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212135001.GW23615@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).