From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 0/4] Misc cleanups of btrfs_get_extent
Date: Mon, 17 Dec 2018 10:35:58 +0200 [thread overview]
Message-ID: <20181217083602.10166-1-nborisov@suse.com> (raw)
Here is a series that hopefully makes the code a bit more obvious. First patch
gives a variable a more appropraite name, since it's going to be used only for
holding an extent type and not the type of a found item.
Patch 2 simply consolidated separate 'if' statements that check the retval of
the same function into a single 'if() {} else if () {}' statement. IMO this is
cleaner.
Patch 3 massages the abhorrent code that deals with btrfs_lookup_file_extent
retval. It groups everything in a coherent 'if() {} else if () {} else {}'
construct and now it's obvious under what conditions specific code is executed.
Finally, Patch 4 removes the not_found_em labelin the same function.
Nikolay Borisov (4):
btrfs: Rename found_type to extent_type
btrfs: Consolidate retval checking of core btree functions
btrfs: Refactor retval handling of btrfs_lookup_file_extent in
btrfs_get_extent
btrfs: Remove not_found_em label from btrfs_get_extent
fs/btrfs/inode.c | 67 ++++++++++++++++++++++++------------------------
1 file changed, 34 insertions(+), 33 deletions(-)
--
2.17.1
next reply other threads:[~2018-12-17 8:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 8:35 Nikolay Borisov [this message]
2018-12-17 8:35 ` [PATCH 1/4] btrfs: Rename found_type to extent_type Nikolay Borisov
2018-12-17 8:54 ` Johannes Thumshirn
2018-12-17 9:05 ` Qu Wenruo
2018-12-17 8:36 ` [PATCH 2/4] btrfs: Consolidate retval checking of core btree functions Nikolay Borisov
2018-12-17 8:55 ` Johannes Thumshirn
2018-12-17 8:57 ` Nikolay Borisov
2018-12-17 9:09 ` Qu Wenruo
2018-12-17 9:23 ` Nikolay Borisov
2018-12-17 9:49 ` [PATCH v2 " Nikolay Borisov
2018-12-17 11:00 ` Qu Wenruo
2018-12-17 8:36 ` [PATCH 3/4] btrfs: Refactor retval handling of btrfs_lookup_file_extent in btrfs_get_extent Nikolay Borisov
2018-12-17 9:07 ` Johannes Thumshirn
2019-01-02 17:05 ` David Sterba
2019-01-02 17:43 ` Nikolay Borisov
2019-01-07 15:22 ` Johannes Thumshirn
2019-01-07 18:46 ` David Sterba
2019-01-08 7:43 ` Nikolay Borisov
2018-12-17 8:36 ` [PATCH 4/4] btrfs: Remove not_found_em label from btrfs_get_extent Nikolay Borisov
2018-12-17 9:08 ` Johannes Thumshirn
2019-01-02 17:08 ` [PATCH 0/4] Misc cleanups of btrfs_get_extent David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217083602.10166-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).