linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Su Yue <suy.fnst@cn.fujitsu.com>
Subject: [PATCH 05/13] btrfs-progs: lowmem: check unaligned disk_bytenr for extent_data
Date: Tue, 18 Dec 2018 18:46:38 +0800	[thread overview]
Message-ID: <20181218104646.29599-6-wqu@suse.com> (raw)
In-Reply-To: <20181218104646.29599-1-wqu@suse.com>

From: Su Yue <suy.fnst@cn.fujitsu.com>

Add support to check unaligned disk_bytenr for extent_data.

Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
 check/mode-lowmem.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c
index b7690c6dc1f1..20663617d242 100644
--- a/check/mode-lowmem.c
+++ b/check/mode-lowmem.c
@@ -3166,7 +3166,14 @@ static int check_extent_data_item(struct btrfs_root *root,
 	extent_num_bytes = btrfs_file_extent_num_bytes(eb, fi);
 	offset = btrfs_file_extent_offset(eb, fi);
 
-	/* Check unaligned disk_num_bytes and num_bytes */
+	/* Check unaligned disk_bytenr, disk_num_bytes and num_bytes */
+	if (!IS_ALIGNED(disk_bytenr, root->fs_info->sectorsize)) {
+		error(
+"file extent [%llu, %llu] has unaligned disk bytenr: %llu, should be aligned to %u",
+			fi_key.objectid, fi_key.offset, disk_bytenr,
+			root->fs_info->sectorsize);
+		err |= BYTES_UNALIGNED;
+	}
 	if (!IS_ALIGNED(disk_num_bytes, root->fs_info->sectorsize)) {
 		error(
 "file extent [%llu, %llu] has unaligned disk num bytes: %llu, should be aligned to %u",
-- 
2.20.0


  parent reply	other threads:[~2018-12-18 10:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-18 10:46 [PATCH 00/13] btrfs-progs: check: Fix Qu Wenruo
2018-12-18 10:46 ` [PATCH 01/13] btrfs-progs: lowmem: fix false alert about the existence of gaps in the check_file_extent Qu Wenruo
2018-12-18 10:46 ` [PATCH 02/13] btrfs-progs: lowmem: add argument path to punch_extent_hole() Qu Wenruo
2018-12-18 10:46 ` [PATCH 03/13] btrfs-progs: lowmem: move nbytes check before isize check Qu Wenruo
2018-12-18 10:46 ` [PATCH 04/13] btrfs-progs: lowmem: fix false alert if extent item has been repaired Qu Wenruo
2018-12-18 10:46 ` Qu Wenruo [this message]
2018-12-18 10:46 ` [PATCH 06/13] btrfs-progs: lowmem: rename delete_extent_tree_item() to delete_item() Qu Wenruo
2018-12-18 10:46 ` [PATCH 07/13] btrfs-progs: lowmem: delete unaligned bytes extent data under repair Qu Wenruo
2018-12-18 10:46 ` [PATCH 08/13] btrfs-progs: Revert "btrfs-progs: Add repair and report function for orphan file extent." Qu Wenruo
2018-12-18 10:46 ` [PATCH 09/13] btrfs-progs: Revert "btrfs-progs: Record orphan data extent ref to corresponding root." Qu Wenruo
2018-12-18 10:46 ` [PATCH 10/13] btrfs-progs: check: fix wrong @offset used in find_possible_backrefs() Qu Wenruo
2018-12-18 10:46 ` [PATCH 11/13] btrfs-progs: check: Delete file extent item with unaligned disk bytenr Qu Wenruo
2018-12-18 10:46 ` [PATCH 12/13] btrfs-progs: tests: add case for inode lose one file extent Qu Wenruo
2018-12-18 10:46 ` [PATCH 13/13] btrfs-progs: fsck-test: enable lowmem repair for case 001 Qu Wenruo
2018-12-18 11:51 ` [PATCH 00/13] btrfs-progs: check: Fix Su Yue
  -- strict thread matches above, loose matches on Subject: below --
2018-10-23  9:41 [PATCH 00/13] btrfs-progs: fixes of file extent in original and lowmem check Su Yue
2018-10-23  9:41 ` [PATCH 05/13] btrfs-progs: lowmem: check unaligned disk_bytenr for extent_data Su Yue
2018-10-24  0:13   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181218104646.29599-6-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=suy.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).