Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: dsterba@suse.cz, Josef Bacik <josef@toxicpanda.com>,
	linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/3][V2] Delayed iput fixes
Date: Fri, 11 Jan 2019 10:09:40 -0500
Message-ID: <20190111150939.k7ddtqayqa5hnkdj@macbook-pro-91.dhcp.thefacebook.com> (raw)
In-Reply-To: <20190108153438.GG23615@twin.jikos.cz>

On Tue, Jan 08, 2019 at 04:34:39PM +0100, David Sterba wrote:
> On Mon, Dec 03, 2018 at 11:06:49AM -0500, Josef Bacik wrote:
> > v1->v2:
> > - only wakeup if the cleaner isn't currently doing work.
> > - re-arranged some stuff for running delayed iputs during flushint.
> > - removed the open code wakeup in the waitqueue patch.
> > 
> > -- Original message --
> > 
> > Here are some delayed iput fixes.  Delayed iputs can hold reservations for a
> > while and there's no real good way to make sure they were gone for good, which
> > means we could early enospc when in reality if we had just waited for the iput
> > we would have had plenty of space.  So fix this up by making us wait for delayed
> > iputs when deciding if we need to commit for enospc flushing, and then cleanup
> > and rework how we run delayed iputs to make it more straightforward to wait on
> > them and make sure we're all done using them.  Thanks,
> 
> I'd like to push this patchset to 5.0, can you please post the missing
> rationale for 2/3? I'm not expecting any code changes so it's just the
> text, I can update the patch, no need to resend the whole series.
> Thanks.

Sorry I saw this earlier this week and then promptly forgot about it, I'll send
it shortly.  Thanks,

Josef

      reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 16:06 Josef Bacik
2018-12-03 16:06 ` [PATCH 1/3] btrfs: run delayed iputs before committing Josef Bacik
2018-12-04  9:03   ` Nikolay Borisov
2018-12-03 16:06 ` [PATCH 2/3] btrfs: wakeup cleaner thread when adding delayed iput Josef Bacik
2018-12-04  9:21   ` Nikolay Borisov
2018-12-04 18:18     ` Josef Bacik
2018-12-03 16:06 ` [PATCH 3/3] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue Josef Bacik
2018-12-04 11:46   ` Nikolay Borisov
2018-12-04 18:21     ` Josef Bacik
2019-01-08 15:34 ` [PATCH 0/3][V2] Delayed iput fixes David Sterba
2019-01-11 15:09   ` Josef Bacik [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190111150939.k7ddtqayqa5hnkdj@macbook-pro-91.dhcp.thefacebook.com \
    --to=josef@toxicpanda.com \
    --cc=dsterba@suse.cz \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org linux-btrfs@archiver.kernel.org
	public-inbox-index linux-btrfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox