Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] btrfs: remove unused workqueue helpers
@ 2019-01-17 16:15 David Sterba
  2019-01-17 16:16 ` Nikolay Borisov
  2019-01-21 17:50 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: David Sterba @ 2019-01-17 16:15 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Sterba

The _owner helpers havent' been used since its introduction in
cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are
no external users of the private wq::fs_info pointer.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/async-thread.c | 12 ------------
 fs/btrfs/async-thread.h |  2 --
 2 files changed, 14 deletions(-)

diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
index d522494698fa..44a7942f0457 100644
--- a/fs/btrfs/async-thread.c
+++ b/fs/btrfs/async-thread.c
@@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg)		\
 	normal_work_helper(work);					\
 }
 
-struct btrfs_fs_info *
-btrfs_workqueue_owner(const struct __btrfs_workqueue *wq)
-{
-	return wq->fs_info;
-}
-
-struct btrfs_fs_info *
-btrfs_work_owner(const struct btrfs_work *work)
-{
-	return work->wq->fs_info;
-}
-
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq)
 {
 	/*
diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h
index 7861c9feba5f..3aceb2e6373a 100644
--- a/fs/btrfs/async-thread.h
+++ b/fs/btrfs/async-thread.h
@@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq,
 void btrfs_destroy_workqueue(struct btrfs_workqueue *wq);
 void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max);
 void btrfs_set_work_high_priority(struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work);
-struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq);
 bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq);
 
 #endif
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: remove unused workqueue helpers
  2019-01-17 16:15 [PATCH] btrfs: remove unused workqueue helpers David Sterba
@ 2019-01-17 16:16 ` Nikolay Borisov
  2019-01-21 17:50 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2019-01-17 16:16 UTC (permalink / raw)
  To: David Sterba, linux-btrfs



On 17.01.19 г. 18:15 ч., David Sterba wrote:
> The _owner helpers havent' been used since its introduction in
> cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are
> no external users of the private wq::fs_info pointer.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/async-thread.c | 12 ------------
>  fs/btrfs/async-thread.h |  2 --
>  2 files changed, 14 deletions(-)
> 
> diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c
> index d522494698fa..44a7942f0457 100644
> --- a/fs/btrfs/async-thread.c
> +++ b/fs/btrfs/async-thread.c
> @@ -61,18 +61,6 @@ noinline_for_stack void btrfs_##name(struct work_struct *arg)		\
>  	normal_work_helper(work);					\
>  }
>  
> -struct btrfs_fs_info *
> -btrfs_workqueue_owner(const struct __btrfs_workqueue *wq)
> -{
> -	return wq->fs_info;
> -}
> -
> -struct btrfs_fs_info *
> -btrfs_work_owner(const struct btrfs_work *work)
> -{
> -	return work->wq->fs_info;
> -}
> -
>  bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq)
>  {
>  	/*
> diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h
> index 7861c9feba5f..3aceb2e6373a 100644
> --- a/fs/btrfs/async-thread.h
> +++ b/fs/btrfs/async-thread.h
> @@ -70,8 +70,6 @@ void btrfs_queue_work(struct btrfs_workqueue *wq,
>  void btrfs_destroy_workqueue(struct btrfs_workqueue *wq);
>  void btrfs_workqueue_set_max(struct btrfs_workqueue *wq, int max);
>  void btrfs_set_work_high_priority(struct btrfs_work *work);
> -struct btrfs_fs_info *btrfs_work_owner(const struct btrfs_work *work);
> -struct btrfs_fs_info *btrfs_workqueue_owner(const struct __btrfs_workqueue *wq);
>  bool btrfs_workqueue_normal_congested(const struct btrfs_workqueue *wq);
>  
>  #endif
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: remove unused workqueue helpers
  2019-01-17 16:15 [PATCH] btrfs: remove unused workqueue helpers David Sterba
  2019-01-17 16:16 ` Nikolay Borisov
@ 2019-01-21 17:50 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-01-21 17:50 UTC (permalink / raw)
  To: David Sterba; +Cc: linux-btrfs

On Thu, Jan 17, 2019 at 05:15:12PM +0100, David Sterba wrote:
> The _owner helpers havent' been used since its introduction in
> cb001095ca705dcd95 ("btrfs: plumb fs_info into btrfs_work"), there are
> no external users of the private wq::fs_info pointer.

Tracepoints ... patch dropped.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 16:15 [PATCH] btrfs: remove unused workqueue helpers David Sterba
2019-01-17 16:16 ` Nikolay Borisov
2019-01-21 17:50 ` David Sterba

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org linux-btrfs@archiver.kernel.org
	public-inbox-index linux-btrfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox