From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A786C282D0 for ; Tue, 29 Jan 2019 18:06:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DED621848 for ; Tue, 29 Jan 2019 18:06:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="xOY//dpo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729062AbfA2SGQ (ORCPT ); Tue, 29 Jan 2019 13:06:16 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46297 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728214AbfA2SGQ (ORCPT ); Tue, 29 Jan 2019 13:06:16 -0500 Received: by mail-qk1-f194.google.com with SMTP id q1so12049079qkf.13 for ; Tue, 29 Jan 2019 10:06:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5wNE0HV5mvZVQ9rThDrqHS4OERbxFOIR6q7tTWzLOKY=; b=xOY//dpoHTVUwSZfXZ/05OjwDr0eF+y/2Y6bmSq3zkXheRGFMsDGg1qdJq3wtc5STH lb0YOkAJeD0agD6UrailHN7236stm9yD5bwleGOB+xJdj2XuQottg45Iv8JqosUdHRXT ojB8zhW1G5Gi+PfF2l71gXrwc6A0KHSpbxP9YfmmGoCvYDpMnYv8pEVKQ6rNAeNGENsz WGRTqNh0wFlXU+zyYLGVg2oYmpq0JALL5odLklyruosv59nJi780zLiwyjXoAq5MH8UC YOJgGSZpO3Txw6p+PAKVOJU9p/oAlcG7xaDmGi6ZRBtcOKVqQGJ4Ty86hcQTsdNq2ROB tE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5wNE0HV5mvZVQ9rThDrqHS4OERbxFOIR6q7tTWzLOKY=; b=J6NfH/qpKAKcdz76nnm5Pc7V0IZX+tPnsQYIUdZoL2lbPj/7hOoUD1gHrDvykyfcx0 B3kh9KkW6tqpck2WFcqZ/+xvK0tn6cJnyLPaOtZWlSZ2vQCF8pG0IQWRI3wQzur3IfqP 5PyCrYLIIEHfIvdU+cbsmykat75wjhzeYEXl3xFye2F7ADTgxFqKfyiMtlZv7h/203rH w5c5OCfgNIP1uogFrpmg7eV6+Vt3H09BDsOoti47XGLbslSr4Po2YPsPHOk9MmqHjS2T xTCfP6rNPNBIxz7iH82grOmhTNDEOCa33vyFWaF9wuCTKmOr+CEj3z25nMIi8XRfe66s egqA== X-Gm-Message-State: AJcUukeWVyYpHeicaSSTlCfVi/Al2o8SIdFqhrLnDfo/CwGHi8KkpwfG o9idMHu1pSCzmZvczQXRq2JTeA== X-Google-Smtp-Source: ALg8bN5OiT6B5uDi2ytO0Ovt3RiW4nREYjxhJNEamHsz0esCnkgcXtZvsqppNmUmdj4oM0X0MYCh4g== X-Received: by 2002:a37:7885:: with SMTP id t127mr24899602qkc.323.1548785175262; Tue, 29 Jan 2019 10:06:15 -0800 (PST) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id s46sm88555537qtc.63.2019.01.29.10.06.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 10:06:14 -0800 (PST) Date: Tue, 29 Jan 2019 13:06:13 -0500 From: Josef Bacik To: Dennis Zhou Cc: David Sterba , Josef Bacik , Chris Mason , Omar Sandoval , Nick Terrell , kernel-team@fb.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/11] btrfs: add compression interface in (get/put)_workspace() Message-ID: <20190129180612.2su6scf3mcuj4bdd@MacBook-Pro-91.local> References: <20190128212437.11597-1-dennis@kernel.org> <20190128212437.11597-7-dennis@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190128212437.11597-7-dennis@kernel.org> User-Agent: NeoMutt/20180716 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Jan 28, 2019 at 04:24:32PM -0500, Dennis Zhou wrote: > There are two levels of workspace management. First, alloc()/free() > which are responsible for actually creating and destroy workspaces. > Second, at a higher level, get()/put() which is the compression code > asking for a workspace from a workspace_manager. > > The compression code shouldn't really care how it gets a workspace, but > that it got a workspace. This adds get_workspace() and put_workspace() > to be the higher level interface which is responsible for indexing into > the appropriate compression type. It also introduces > btrfs_put_workspace() and btrfs_get_workspace() to be the generic > implementations of the higher interface. > > Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik Thanks, Josef