From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 04/12] btrfs: extent_io: Move the BUG_ON() in flush_write_bio() one level up
Date: Thu, 31 Jan 2019 15:36:37 +0100 [thread overview]
Message-ID: <20190131143637.GF2900@twin.jikos.cz> (raw)
In-Reply-To: <3893155e-d3c3-5fd0-6f61-ae067d341d81@gmx.com>
On Thu, Jan 31, 2019 at 08:45:42AM +0800, Qu Wenruo wrote:
>
>
> On 2019/1/30 下午11:19, David Sterba wrote:
> > On Fri, Jan 25, 2019 at 01:09:17PM +0800, Qu Wenruo wrote:
> >> +static int __must_check flush_write_bio(struct extent_page_data *epd)
> >> {
> >> - if (epd->bio) {
> >> - int ret;
> >> + int ret = 0;
> >>
> >> + if (epd->bio) {
> >> ret = submit_one_bio(epd->bio, 0, 0);
> >> - BUG_ON(ret < 0); /* -ENOMEM */
> >> epd->bio = NULL;
> >
> > I'm not sure if resetting epd->bio to NULL is all that needs to be done
> > here. With the BUG_ON the error case never happens so if all goes fine
> > it's also ok to set it to NULL and continue. But the callers might need
> > to send the flush again.
>
> If flush_write_bio() get called again on the failed one, it will just
> get skipped as epd->bio is NULL, submit_one_bio() will not be triggered.
Yes that's clear, but what is the state of the bio that went to
flush_write_bio and submit_one_bio failed?
next prev parent reply other threads:[~2019-01-31 14:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 5:09 [PATCH v4 00/12] btrfs: Enhancement to tree block validation Qu Wenruo
2019-01-25 5:09 ` [PATCH v4 01/12] btrfs: Always output error message when key/level verification fails Qu Wenruo
2019-01-25 9:02 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 02/12] btrfs: extent_io: Kill the forward declaration of flush_write_bio() Qu Wenruo
2019-01-25 5:09 ` [PATCH v4 03/12] btrfs: disk-io: Show the timing of corrupted tree block explicitly Qu Wenruo
2019-01-25 9:03 ` Johannes Thumshirn
2019-01-30 14:57 ` David Sterba
2019-01-30 14:59 ` Nikolay Borisov
2019-01-31 0:03 ` Qu Wenruo
2019-01-31 14:20 ` David Sterba
2019-01-31 14:22 ` Nikolay Borisov
2019-02-07 17:27 ` David Sterba
2019-01-25 5:09 ` [PATCH v4 04/12] btrfs: extent_io: Move the BUG_ON() in flush_write_bio() one level up Qu Wenruo
2019-01-25 9:04 ` Johannes Thumshirn
2019-01-30 15:08 ` David Sterba
2019-01-30 15:19 ` David Sterba
2019-01-31 0:45 ` Qu Wenruo
2019-01-31 14:36 ` David Sterba [this message]
2019-02-15 7:18 ` Qu Wenruo
2019-02-15 9:58 ` Qu Wenruo
2019-01-25 5:09 ` [PATCH v4 05/12] btrfs: extent_io: Kill the BUG_ON() in extent_write_full_page() Qu Wenruo
2019-01-25 9:05 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 06/12] btrfs: extent_io: Kill the BUG_ON() in btree_write_cache_pages() Qu Wenruo
2019-01-25 9:11 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 07/12] btrfs: extent_io: Kill the dead branch in extent_write_cache_pages() Qu Wenruo
2019-01-25 9:11 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 08/12] btrfs: extent_io: Kill the BUG_ON() in extent_write_locked_range() Qu Wenruo
2019-01-25 5:09 ` [PATCH v4 09/12] btrfs: extent_io: Kill the BUG_ON() in lock_extent_buffer_for_io() Qu Wenruo
2019-01-25 5:09 ` [PATCH v4 10/12] btrfs: extent_io: Kill the BUG_ON() in extent_write_cache_pages() Qu Wenruo
2019-01-25 9:16 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 11/12] btrfs: extent_io: Kill the BUG_ON() in extent_writepages() Qu Wenruo
2019-01-25 9:16 ` Johannes Thumshirn
2019-01-25 5:09 ` [PATCH v4 12/12] btrfs: Do mandatory tree block check before submitting bio Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131143637.GF2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).