From: David Sterba <dsterba@suse.cz>
To: David Sterba <dsterba@suse.cz>
Cc: Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 3/3] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue
Date: Tue, 5 Feb 2019 19:23:03 +0100 [thread overview]
Message-ID: <20190205182302.GW2900@twin.jikos.cz> (raw)
In-Reply-To: <20190116191216.GQ2900@twin.jikos.cz>
On Wed, Jan 16, 2019 at 08:12:16PM +0100, David Sterba wrote:
> > +/**
> > + * btrfs_wait_on_delayed_iputs - wait on the delayed iputs to be done running
> > + * @fs_info - the fs_info for this fs
> > + * @return - EINTR if we were killed, 0 if nothing's pending
> > + *
> > + * This will wait on any delayed iputs that are currently running with KILLABLE
> > + * set. Once they are all done running we will return, unless we are killed in
> > + * which case we return EINTR.
>
> I still wonder from which context the 'killable' property is used.
>
> btrfs_alloc_data_chunk_ondemand is indirectly inside zero range and
> fallocate, there it makes sense. With flush_space is less obvious, so
> this should be explained in the changelog what's expected.
Something along those lines is now in the changelog and patch goes to
misc-next.
next prev parent reply other threads:[~2019-02-05 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 15:21 [PATCH 0/3][V3] Delayed iput fixes Josef Bacik
2019-01-11 15:21 ` [PATCH 1/3] btrfs: run delayed iputs before committing Josef Bacik
2019-01-11 15:21 ` [PATCH 2/3] btrfs: wakeup cleaner thread when adding delayed iput Josef Bacik
2019-01-11 15:21 ` [PATCH 3/3] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue Josef Bacik
2019-01-16 19:12 ` David Sterba
2019-02-05 18:23 ` David Sterba [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-03 16:06 [PATCH 0/3][V2] Delayed iput fixes Josef Bacik
2018-12-03 16:06 ` [PATCH 3/3] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue Josef Bacik
2018-12-04 11:46 ` Nikolay Borisov
2018-12-04 18:21 ` Josef Bacik
2018-11-21 19:09 [PATCH 0/3] Delayed iput fixes Josef Bacik
2018-11-21 19:09 ` [PATCH 3/3] btrfs: replace cleaner_delayed_iput_mutex with a waitqueue Josef Bacik
2018-11-27 8:29 ` Nikolay Borisov
2018-11-27 20:01 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190205182302.GW2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).