Linux-BTRFS Archive on lore.kernel.org
 help / Atom feed
* Re: linux-next: Tree for Feb 5 (btrfs/zstd)
       [not found] <20190205171228.41a9f771@canb.auug.org.au>
@ 2019-02-05 17:40 ` Randy Dunlap
  2019-02-05 18:25   ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-02-05 17:40 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List
  Cc: Linux Kernel Mailing List, Linux Btrfs

On 2/4/19 10:12 PM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20190204:
> 

on i386:

../fs/btrfs/zstd.c: In function ‘zstd_reclaim_timer_fn’:
../fs/btrfs/zstd.c:27:35: warning: integer overflow in expression [-Woverflow]
 #define ZSTD_BTRFS_RECLAIM_NS (45 * NSEC_PER_SEC)
                                   ^
../fs/btrfs/zstd.c:96:33: note: in expansion of macro ‘ZSTD_BTRFS_RECLAIM_NS’
   if (now < victim->last_used + ZSTD_BTRFS_RECLAIM_NS)
                                 ^


-- 
~Randy

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: linux-next: Tree for Feb 5 (btrfs/zstd)
  2019-02-05 17:40 ` linux-next: Tree for Feb 5 (btrfs/zstd) Randy Dunlap
@ 2019-02-05 18:25   ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2019-02-05 18:25 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Stephen Rothwell, Linux Next Mailing List,
	Linux Kernel Mailing List, Linux Btrfs

On Tue, Feb 05, 2019 at 09:40:40AM -0800, Randy Dunlap wrote:
> On 2/4/19 10:12 PM, Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20190204:
> > 
> 
> on i386:
> 
> ../fs/btrfs/zstd.c: In function ‘zstd_reclaim_timer_fn’:
> ../fs/btrfs/zstd.c:27:35: warning: integer overflow in expression [-Woverflow]
>  #define ZSTD_BTRFS_RECLAIM_NS (45 * NSEC_PER_SEC)
>                                    ^
> ../fs/btrfs/zstd.c:96:33: note: in expansion of macro ‘ZSTD_BTRFS_RECLAIM_NS’
>    if (now < victim->last_used + ZSTD_BTRFS_RECLAIM_NS)

Thanks for the report. There's a v2 of the patchset that uses the
timer_after helper and this warning should be gone. The updated version
will appear in for-next soonish.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20190205171228.41a9f771@canb.auug.org.au>
2019-02-05 17:40 ` linux-next: Tree for Feb 5 (btrfs/zstd) Randy Dunlap
2019-02-05 18:25   ` David Sterba

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org linux-btrfs@archiver.kernel.org
	public-inbox-index linux-btrfs


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox