From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: don't end the transaction for delayed refs in throttle
Date: Tue, 12 Feb 2019 17:03:52 +0100 [thread overview]
Message-ID: <20190212160351.GD2900@twin.jikos.cz> (raw)
In-Reply-To: <20190124143143.8838-1-josef@toxicpanda.com>
On Thu, Jan 24, 2019 at 09:31:43AM -0500, Josef Bacik wrote:
> Previously callers to btrfs_end_transaction_throttle() would commit the
> transaction if there wasn't enough delayed refs space. This happens in
> relocation, and if the fs is relatively empty we'll run out of delayed
> refs space basically immediately, so we'll just be stuck in this loop of
> committing the transaction over and over again.
>
> This code existed because we didn't have a good feedback mechanism for
> running delayed refs, but with the delayed refs rsv we do now. Delete
> this throttling code and let the btrfs_start_transaction() in relocation
> deal with putting pressure on the delayed refs infrastructure. With
> this patch we no longer take 5 minutes to balance a metadata only fs.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
For the record, this has been merged to 5.0-rc5
next prev parent reply other threads:[~2019-02-12 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 14:31 [PATCH] btrfs: don't end the transaction for delayed refs in throttle Josef Bacik
2019-02-12 16:03 ` David Sterba [this message]
2019-06-03 6:53 ` Qu Wenruo
2019-06-03 17:36 ` Josef Bacik
2019-06-03 18:43 ` David Sterba
2019-06-04 0:31 ` Qu Wenruo
2019-06-04 17:43 ` Josef Bacik
2019-07-04 6:56 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212160351.GD2900@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).