From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098FFC43381 for ; Mon, 18 Feb 2019 16:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC130217F5 for ; Mon, 18 Feb 2019 16:00:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731296AbfBRQAc (ORCPT ); Mon, 18 Feb 2019 11:00:32 -0500 Received: from mx2.suse.de ([195.135.220.15]:45648 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728977AbfBRQAc (ORCPT ); Mon, 18 Feb 2019 11:00:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 5884DB03C; Mon, 18 Feb 2019 16:00:31 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 525E9DA870; Mon, 18 Feb 2019 17:01:55 +0100 (CET) Date: Mon, 18 Feb 2019 17:01:55 +0100 From: David Sterba To: fdmanana@kernel.org Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 3/4] Btrfs: check if destination root is read-only for deduplication Message-ID: <20190218160155.GM9874@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, fdmanana@kernel.org, linux-btrfs@vger.kernel.org References: <20181212180559.15249-1-fdmanana@kernel.org> <20181212180559.15249-4-fdmanana@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181212180559.15249-4-fdmanana@kernel.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Dec 12, 2018 at 06:05:58PM +0000, fdmanana@kernel.org wrote: > From: Filipe Manana > > Checking if the destination root is read-only was being performed only for > clone operations. Make deduplication check it as well, as it does not make > sense to not do it, even if it is an operation that does not change the > file contents (such as defrag for example, which checks first if the root > is read-only). > > Signed-off-by: Filipe Manana I've copied the portions of our discussion and added the patch to misc-next.