From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: balance: Sync the fs before balancing metadata chunks
Date: Mon, 25 Feb 2019 18:21:19 +0100 [thread overview]
Message-ID: <20190225172118.GA24609@twin.jikos.cz> (raw)
In-Reply-To: <20190129065739.31707-1-wqu@suse.com>
On Tue, Jan 29, 2019 at 02:57:39PM +0800, Qu Wenruo wrote:
> The most straightforward is to sync the fs before balancing metadata
> chunks.
>
> We could enhance the kernel bytes_may_use calculation, but I doubt about
> the complexity.
> So I take the easy fix to reduce the false ENOSPC reports.
Agreed.
> + /*
> + * There may be many over-reserved space for metadata block groups,
> + * especially for inlined file extents.
> + *
> + * Do a sync here will free those over-reserved space and hugely
> + * reduce the possibility of some false ENOSPC
> + */
> + if (args->flags & BTRFS_BALANCE_METADATA) {
> + ret = btrfs_util_sync(path);
As the fd is already open, we should use the _fd version,
> + if (ret) {
> + error("failed to sync the fs before balance: %m");
> + ret = -errno;
> + goto out;
and possibly only warn if there's an error returned as the sync failure
is not a critical condition.
next prev parent reply other threads:[~2019-02-25 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 6:57 [PATCH] btrfs-progs: balance: Sync the fs before balancing metadata chunks Qu Wenruo
2019-02-25 17:21 ` David Sterba [this message]
2019-02-26 5:55 ` Qu Wenruo
2019-02-27 16:25 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190225172118.GA24609@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).