From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 1/5] btrfs: extent_io: Add comment about the return value of alloc_extent_buffer()
Date: Wed, 27 Feb 2019 14:44:46 +0100 [thread overview]
Message-ID: <20190227134446.GK24609@twin.jikos.cz> (raw)
In-Reply-To: <1471706f-ace7-b69c-4fd1-b1877128b813@gmx.com>
On Wed, Feb 27, 2019 at 09:41:17PM +0800, Qu Wenruo wrote:
>
>
> On 2019/2/27 下午9:36, David Sterba wrote:
> > On Fri, Feb 22, 2019 at 06:16:40PM +0800, Qu Wenruo wrote:
> >> To inform later developers how to check the return value of it.
> >>
> >> Signed-off-by: Qu Wenruo <wqu@suse.com>
> >> ---
> >> fs/btrfs/extent_io.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> >> index 52abe4082680..b28a75546700 100644
> >> --- a/fs/btrfs/extent_io.c
> >> +++ b/fs/btrfs/extent_io.c
> >> @@ -4890,6 +4890,13 @@ struct extent_buffer *alloc_test_extent_buffer(struct btrfs_fs_info *fs_info,
> >> }
> >> #endif
> >>
> >> +/*
> >> + * Allocate an extent buffer structure, with all its pages attached and locked.
> >> + *
> >> + * Return valid pointer if nothing goes wrong.
> >> + * Return PTR_ERR() if failed.
> >> + * Will never return NULL.
> >
> > I'd rather drop this as it depends on another function and the
> > GFP_NOFAIL flag that will be removed eventually. The PTR_ERR covers
> > ENOMEM and allocation failures.
> >
>
> I'm completely OK with the removal.
>
> Do need to resend this patch?
Wait, I'm going through the rest.
next prev parent reply other threads:[~2019-02-27 13:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 10:16 [PATCH 0/5] Unify the return value of alloc/clone_extent_buffer() Qu Wenruo
2019-02-22 10:16 ` [PATCH 1/5] btrfs: extent_io: Add comment about the return value of alloc_extent_buffer() Qu Wenruo
2019-02-27 13:36 ` David Sterba
2019-02-27 13:41 ` Qu Wenruo
2019-02-27 13:44 ` David Sterba [this message]
2019-02-22 10:16 ` [PATCH 2/5] btrfs: extent_io: Unify the return value of __alloc_extent_buffer() with alloc_extent_buffer() Qu Wenruo
2019-02-22 10:16 ` [PATCH 3/5] btrfs: extent_io: Unify the return value of alloc_dummy_extent_buffer() " Qu Wenruo
2019-02-22 10:16 ` [PATCH 4/5] btrfs: extent_io: Unify the return value of alloc_test_extent_buffer() " Qu Wenruo
2019-02-22 10:16 ` [PATCH 5/5] btrfs: extent_io: Unify the return value of btrfs_clone_extent_buffer() " Qu Wenruo
2019-02-22 12:47 ` Nikolay Borisov
2019-02-22 12:53 ` Qu Wenruo
2019-02-22 13:02 ` [PATCH v1.1 " Qu Wenruo
2019-02-22 12:54 ` [PATCH 0/5] Unify the return value of alloc/clone_extent_buffer() Nikolay Borisov
2019-02-22 13:02 ` Qu Wenruo
2019-02-22 13:29 ` Nikolay Borisov
2019-02-22 13:31 ` Qu Wenruo
2019-02-27 14:11 ` David Sterba
2019-02-22 13:32 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227134446.GK24609@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).