From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v4 03/10] btrfs: trivial, fix c coding style
Date: Wed, 27 Feb 2019 17:05:23 +0100 [thread overview]
Message-ID: <20190227160523.GS24609@twin.jikos.cz> (raw)
In-Reply-To: <1550857192-10513-4-git-send-email-anand.jain@oracle.com>
On Sat, Feb 23, 2019 at 01:39:45AM +0800, Anand Jain wrote:
> Maintain the lines extented upto 80 char where possible, and indent the
> argument.
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
I don't think such patches are necessary, there's a lot of strange
formatting from the past and we could fix the ugly ones but otherwise
strive to fix everything before it gets merged. I do a lot of fixups
just before the final merge, but having everybody follow the same coding
style is near to impossible.
next prev parent reply other threads:[~2019-02-27 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 17:39 [PATCH v4 00/10] Misc props.c cleanups Anand Jain
2019-02-22 17:39 ` [PATCH v4 01/10] btrfs: kill __btrfs_set_prop() Anand Jain
2019-02-22 17:39 ` [PATCH v4 02/10] btrfs: drop redundant forward declaration in props.c Anand Jain
2019-02-22 17:39 ` [PATCH v4 03/10] btrfs: trivial, fix c coding style Anand Jain
2019-02-27 16:05 ` David Sterba [this message]
2019-02-28 9:50 ` Anand Jain
2019-02-22 17:39 ` [PATCH v4 04/10] btrfs: rename fs_info argument to fs_private Anand Jain
2019-02-27 16:10 ` David Sterba
2019-02-22 17:39 ` [PATCH v4 05/10] btrfs: refactor btrfs_set_prop add btrfs_set_prop_trans Anand Jain
2019-02-22 17:39 ` [PATCH v4 06/10] btrfs: start transaction in btrfs_set_prop_trans Anand Jain
2019-02-27 16:08 ` David Sterba
2019-02-28 10:36 ` Anand Jain
2019-02-28 16:00 ` David Sterba
2019-02-22 17:39 ` [PATCH v4 07/10] btrfs: start transaction in btrfs_set_acl Anand Jain
2019-02-22 17:39 ` [PATCH v4 08/10] btrfs: start transaction in btrfs_xattr_handler_set Anand Jain
2019-02-22 17:39 ` [PATCH v4 09/10] btrfs: btrfs_setxattr argument trans is never NULL Anand Jain
2019-02-27 16:16 ` David Sterba
2019-02-28 10:40 ` Anand Jain
2019-02-22 17:39 ` [PATCH v4 10/10] btrfs: kill btrfs_setxattr Anand Jain
2019-02-27 16:21 ` David Sterba
2019-02-28 11:10 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227160523.GS24609@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).