From: Johannes Thumshirn <jthumshirn@suse.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2.1 1/3] btrfs: Remove "recovery" mount option
Date: Mon, 15 Apr 2019 11:29:04 +0200 [thread overview]
Message-ID: <20190415092904.GC7586@linux-x5ow.site> (raw)
In-Reply-To: <ae61b9b7-254d-0e58-9350-b822312e3f11@gmx.com>
On Mon, Apr 15, 2019 at 05:08:55PM +0800, Qu Wenruo wrote:
> It is mentioned as deprecated in btrfs(5):
> recovery
> (since: 3.2, default: off, deprecated since: 4.5)
>
> Note
> this option has been replaced by usebackuproot and should not
> be used but will work on 4.5+ kernels.
>
>
> The removal date is not mentioned though.
Hmm ok, just because xfs for example give an schedule for removal of mount
options.
Either way, code wise it looks ok to me:
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn SUSE Labs Filesystems
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-04-15 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 5:36 [PATCH v2.1 0/3] btrfs: Introduce new rescue= mount options Qu Wenruo
2019-04-15 5:36 ` [PATCH v2.1 1/3] btrfs: Remove "recovery" mount option Qu Wenruo
2019-04-15 9:05 ` Johannes Thumshirn
2019-04-15 9:08 ` Qu Wenruo
2019-04-15 9:29 ` Johannes Thumshirn [this message]
2019-04-15 5:36 ` [PATCH v2.1 2/3] btrfs: Introduce "rescue=" " Qu Wenruo
2019-04-15 5:36 ` [PATCH v2.1 3/3] btrfs: Introduce new mount option to skip block group items scan Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190415092904.GC7586@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).