From: Eryu Guan <guaneryu@gmail.com>
To: dsterba@suse.cz, Anand Jain <anand.jain@oracle.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] fstests: btrfs: try use forget to unregister device
Date: Fri, 3 May 2019 19:14:33 +0800 [thread overview]
Message-ID: <20190503111433.GD15846@desktop> (raw)
In-Reply-To: <20190426163542.GW20156@twin.jikos.cz>
On Fri, Apr 26, 2019 at 06:35:42PM +0200, David Sterba wrote:
> On Tue, Apr 02, 2019 at 04:19:46PM +0800, Anand Jain wrote:
> > Some btrfs test cases use btrfs module-reload to unregister devices in
> > the btrfs kernel. The problem with the module-reload approach is, if test
> > system contains btrfs as rootfs, then you can't run these test cases.
> >
> > Patches [1] introduced btrfs forget feature which can unregister devices
> > without the module-reload approach.
> >
> > [1]
> > btrfs-progs: device scan: add new option to forget one or all scanned devices
> > btrfs: introduce new ioctl to unregister a btrfs device
> >
> > And this patch makes relevant changes in the fstests to use this new
> > feature, when available.
> >
> > Signed-off-by: Anand Jain <anand.jain@oracle.com>
> > ---
> > v2:
> > Update change log.
> > Rename _require_btrfs_forget_if_not_fs_loadable() to _require_btrfs_forget_or_module_loadable()
> > Rename _btrfs_forget_if_not_fs_reload() to _btrfs_forget_or_module_reload()
>
> Reviewed-by: David Sterba <dsterba@suse.com>
The patch has already been applied & pushed to upstream, thanks for the
review all the same!
Thanks,
Eryu
prev parent reply other threads:[~2019-05-03 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 9:49 [PATCH] fstests: btrfs try use forget to unregister device Anand Jain
2019-03-23 9:05 ` Eryu Guan
2019-03-28 17:50 ` David Sterba
2019-03-29 6:32 ` Anand Jain
2019-04-02 8:19 ` [PATCH v2] fstests: btrfs: " Anand Jain
2019-04-26 16:35 ` David Sterba
2019-05-03 11:14 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190503111433.GD15846@desktop \
--to=guaneryu@gmail.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).