From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EDC8C04AA7 for ; Mon, 13 May 2019 12:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4381D208C2 for ; Mon, 13 May 2019 12:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728666AbfEMM6p (ORCPT ); Mon, 13 May 2019 08:58:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:41784 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727272AbfEMM6o (ORCPT ); Mon, 13 May 2019 08:58:44 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D507FAD4F for ; Mon, 13 May 2019 12:58:43 +0000 (UTC) Date: Mon, 13 May 2019 14:58:43 +0200 From: Johannes Thumshirn To: dsterba@suse.cz, Nikolay Borisov , Linux BTRFS Mailinglist Subject: Re: [PATCH 17/17] btrfs: add sha256 as another checksum algorithm Message-ID: <20190513125843.GC18838@x250.microfocus.com> References: <20190510111547.15310-1-jthumshirn@suse.de> <20190510111547.15310-18-jthumshirn@suse.de> <20190513125556.GB20156@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190513125556.GB20156@suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, May 13, 2019 at 02:55:56PM +0200, David Sterba wrote: > > nit: case BTRFS_CSUM_TYPE_CRC32: > > CASE BTRFS_CSUM_TYPE_SHA256: > > return true; > > I'm not sure if the -Wimplicit-fallthrough accepts that without the > annotation or not. Looks like it does: jthumshirn@glass:linux (btrfs-csum-rework)$ git show fs/btrfs/disk-io.c diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 342f513db712..1e0000962b8a 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -389,6 +389,7 @@ static bool btrfs_supported_super_csum(struct btrfs_super_block *sb) { switch (btrfs_super_csum_type(sb)) { case BTRFS_CSUM_TYPE_CRC32: + case BTRFS_CSUM_TYPE_SHA256: return true; default: return false; jthumshirn@glass:linux (btrfs-csum-rework)$ touch fs/btrfs/disk-io.c jthumshirn@glass:linux (btrfs-csum-rework)$ make CC=gcc-7 -j 144 W=1 M=fs/btrfs CC [M] fs/btrfs/disk-io.o LD [M] fs/btrfs/btrfs.o Building modules, stage 2. MODPOST 1 modules LD [M] fs/btrfs/btrfs.ko -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850