linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/3] btrfs-progs: Handle error properly in btrfs_commit_transaction()
Date: Mon, 13 May 2019 15:55:48 +0200	[thread overview]
Message-ID: <20190513135548.GA3138@twin.jikos.cz> (raw)
In-Reply-To: <20190416071526.3576-1-wqu@suse.com>

On Tue, Apr 16, 2019 at 03:15:23PM +0800, Qu Wenruo wrote:
> This patchset can be fetched from github:
> https://github.com/adam900710/btrfs-progs/tree/commit_failure_cleanup
> 
> This patchset will address the BUG_ON() triggered in fuzz-tests/003 and
> fuzz-tests/009.
> 
> For proper error handling in btrfs_commit_transaction(), we need a way
> to clean up per-transaction data properly.
> 
> Currently we only have delayed refs which are per-transaction, so
> introduce a new function, btrfs_destroy_delayed_refs() to cleanup
> delayed refs.
> 
> Now btrfs_commit_transaction() can error out gracefully with proper
> cleanup.
> 
> Patch 1 and 2 are just some minor cleanups found when crafting the 3rd
> patch.
> 
> Qu Wenruo (3):
>   btrfs-progs: Remove the dead branch in btrfs_run_delayed_refs()
>   btrfs-progs: Refactor btrfs_finish_extent_commit()
>   btrfs-progs: Handle error properly in btrfs_commit_transaction()

Added to devel, thanks.

      parent reply	other threads:[~2019-05-13 13:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-16  7:15 [PATCH 0/3] btrfs-progs: Handle error properly in btrfs_commit_transaction() Qu Wenruo
2019-04-16  7:15 ` [PATCH 1/3] btrfs-progs: Remove the dead branch in btrfs_run_delayed_refs() Qu Wenruo
2019-04-16  7:36   ` Nikolay Borisov
2019-04-16  7:15 ` [PATCH 2/3] btrfs-progs: Refactor btrfs_finish_extent_commit() Qu Wenruo
2019-04-16  7:39   ` Nikolay Borisov
2019-04-16  7:15 ` [PATCH 3/3] btrfs-progs: Handle error properly in btrfs_commit_transaction() Qu Wenruo
2019-04-16  7:48   ` Nikolay Borisov
2019-05-13 13:55 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190513135548.GA3138@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).