From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCDE0C28CC0 for ; Thu, 30 May 2019 12:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C038B2437C for ; Thu, 30 May 2019 12:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbfE3MDK (ORCPT ); Thu, 30 May 2019 08:03:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:55974 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726993AbfE3MDJ (ORCPT ); Thu, 30 May 2019 08:03:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 55989AEB2 for ; Thu, 30 May 2019 12:03:08 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8168ADA85E; Thu, 30 May 2019 14:04:02 +0200 (CEST) Date: Thu, 30 May 2019 14:04:02 +0200 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: trim: Check the range passed into to prevent overflow Message-ID: <20190530120402.GD15290@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20190528082154.6450-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190528082154.6450-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, May 28, 2019 at 04:21:54PM +0800, Qu Wenruo wrote: > Normally the range->len is set to default value (U64_MAX), but when it's > not default value, we should check if the range overflows. > > And if overflows, return -EINVAL before doing anything. > > Signed-off-by: Qu Wenruo The range support of TRIM will be reverted so this patch won't be needed.