From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A9F7C31E4A for ; Thu, 13 Jun 2019 15:05:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7485F20B7C for ; Thu, 13 Jun 2019 15:05:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="U4iRJrkg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733201AbfFMPFS (ORCPT ); Thu, 13 Jun 2019 11:05:18 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41042 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732450AbfFMOPw (ORCPT ); Thu, 13 Jun 2019 10:15:52 -0400 Received: by mail-qk1-f196.google.com with SMTP id c11so12814391qkk.8 for ; Thu, 13 Jun 2019 07:15:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sbvrt5MZdKQZtIDBTdvl9Mov/hKhPttcrBddG8hlTHo=; b=U4iRJrkgboqXD/9ecVEMGKPpyhkTFeK6mRiuk3Hy6ZSjwXCUQjTvFcN1/3TbP0NwfD Cc0zRy15Gx4ZrC16COD805lwAeHf+qTzSuM79QtyZaBjBOLBNYC4OcekJA1r2UIVSfCF d7WXvg5HrlhBXYtFb5VvFctZCG/Ixpw8iY5IcU88+E9uOEfz1mmm4oqCAf/PiZySI+WX zEsdmJ64iKb2T8hzeutqLaiWHI3UhHek9Rp74I2YSN7P2KgZU/L9RdBvxkx4IV/qxmSt AGAkIzRqZ8bwB2xirmaAcULCaO3AAs2Bs0nonS+DUCjHnU1NBiJuLN34fx159zgfGaVJ GVgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sbvrt5MZdKQZtIDBTdvl9Mov/hKhPttcrBddG8hlTHo=; b=mwbaGXRwIrQZ63CCP45T9Pc8n8YhNOgaJOSfoPOVTgReX76RzJHpdXazj2MgYz8mwZ mQzAyaBefnSvED2o/rVh4FXLgr+08ObaTkFbw0gW7cNfGh5qFhrNv7UHP4XVXYwVMced RvTS8cJjuh1NmwiYL7I24S9x6Pi87NIPloGeaLCzTAsd+7QZeYaVfFVEF1Kwf99+5Phz v1d2wOlMtna4WLkKQ8WS172xZdPehXRvlxkR91rOUUR3JS94pbJZOcI76lyjm/MTi6N/ LrKMm6bRzWwI96a+nBGxt9/HVUce3W4V6pP+lv60EVqH9Z1KnRvJfHma22diGufTAKxI vHDw== X-Gm-Message-State: APjAAAUSve9MZN49pZ8RjrPbF9yCOSU1J0NVpXFOTtHWM9rhZlfSm9GV cO/dFhpqRtmUcm+izpfTTJeEfw== X-Google-Smtp-Source: APXvYqwg9ItFMlhHRYGvsdkND+NywXN/99yJ/OfGCgepby4UQnidXK6DCCbLqQXc5D4yRoAVhsjoyA== X-Received: by 2002:a05:620a:16cc:: with SMTP id a12mr13267398qkn.256.1560435351183; Thu, 13 Jun 2019 07:15:51 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::9d6b]) by smtp.gmail.com with ESMTPSA id t29sm2155361qtt.42.2019.06.13.07.15.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2019 07:15:50 -0700 (PDT) Date: Thu, 13 Jun 2019 10:15:49 -0400 From: Josef Bacik To: Naohiro Aota Cc: linux-btrfs@vger.kernel.org, David Sterba , Chris Mason , Josef Bacik , Qu Wenruo , Nikolay Borisov , linux-kernel@vger.kernel.org, Hannes Reinecke , linux-fsdevel@vger.kernel.org, Damien Le Moal , Matias =?utf-8?B?QmrDuHJsaW5n?= , Johannes Thumshirn , Bart Van Assche Subject: Re: [PATCH 12/19] btrfs: expire submit buffer on timeout Message-ID: <20190613141548.vlczaxiqqzbxgtzk@MacBook-Pro-91.local> References: <20190607131025.31996-1-naohiro.aota@wdc.com> <20190607131025.31996-13-naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190607131025.31996-13-naohiro.aota@wdc.com> User-Agent: NeoMutt/20180716 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Jun 07, 2019 at 10:10:18PM +0900, Naohiro Aota wrote: > It is possible to have bios stalled in the submit buffer due to some bug or > device problem. In such situation, btrfs stops working waiting for buffered > bios completions. To avoid such hang, add a worker that will cancel the > stalled bios after a timeout. > The block layer does this with it's request timeouts right? So it'll timeout and we'll get an EIO? If that's not working then we need to fix the block layer. Thanks, Josef