From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20BC8C48BD7 for ; Thu, 27 Jun 2019 15:28:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 034ED2064A for ; Thu, 27 Jun 2019 15:28:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726668AbfF0P2K (ORCPT ); Thu, 27 Jun 2019 11:28:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:46756 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726187AbfF0P2J (ORCPT ); Thu, 27 Jun 2019 11:28:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 726F6AC41; Thu, 27 Jun 2019 15:28:08 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 4598EDA811; Thu, 27 Jun 2019 17:28:54 +0200 (CEST) Date: Thu, 27 Jun 2019 17:28:54 +0200 From: David Sterba To: Naohiro Aota Cc: "dsterba@suse.cz" , "linux-btrfs@vger.kernel.org" , David Sterba , Chris Mason , Josef Bacik , Qu Wenruo , Nikolay Borisov , "linux-kernel@vger.kernel.org" , Hannes Reinecke , "linux-fsdevel@vger.kernel.org" , Damien Le Moal , Matias =?iso-8859-1?Q?Bj=F8rling?= , Johannes Thumshirn , Bart Van Assche Subject: Re: [PATCH 07/19] btrfs: do sequential extent allocation in HMZONED mode Message-ID: <20190627152854.GC20977@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Naohiro Aota , "linux-btrfs@vger.kernel.org" , David Sterba , Chris Mason , Josef Bacik , Qu Wenruo , Nikolay Borisov , "linux-kernel@vger.kernel.org" , Hannes Reinecke , "linux-fsdevel@vger.kernel.org" , Damien Le Moal , Matias =?iso-8859-1?Q?Bj=F8rling?= , Johannes Thumshirn , Bart Van Assche References: <20190607131025.31996-1-naohiro.aota@wdc.com> <20190607131025.31996-8-naohiro.aota@wdc.com> <20190617223007.GI19057@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Jun 18, 2019 at 08:49:00AM +0000, Naohiro Aota wrote: > On 2019/06/18 7:29, David Sterba wrote: > > On Fri, Jun 07, 2019 at 10:10:13PM +0900, Naohiro Aota wrote: > >> + u64 unusable; > > > > 'unusable' is specific to the zones, so 'zone_unusable' would make it > > clear. The terminilogy around space is confusing already (we have > > unused, free, reserved, allocated, slack). > > Sure. I will change the name. > > Or, is it better toadd new struct "btrfs_seq_alloc_info" and move all > these variable there? Then, I can just add one pointer to the struct here. There are 4 new members, but the block group structure is large already (528 bytes) so adding a few more will not make the allocations worse. There are also holes or inefficient types used so the size can be squeezed a bit, but this is unrelated to this patchset.