From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Anand Jain <anand.jain@oracle.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3 RESEND Rebased] btrfs: add readmirror devid property
Date: Tue, 23 Jul 2019 17:25:09 +0200 [thread overview]
Message-ID: <20190723152509.GG2868@twin.jikos.cz> (raw)
In-Reply-To: <20190723145553.GE2868@twin.jikos.cz>
On Tue, Jul 23, 2019 at 04:55:53PM +0200, David Sterba wrote:
> On Wed, Jun 26, 2019 at 04:34:02PM +0800, Anand Jain wrote:
> > Introduces devid readmirror property, to direct read IO to the specified
> > device(s).
> >
> > The readmirror property is stored as extended attribute on the root
> > inode.
>
> So this is permanently stored on the filesystem, is the policy applied
> at mount time?
Found in some previous version that it's not permanently stored, so
scratch that.
> > The readmirror input format is devid1,2,3.. etc. And for the
> > each devid provided, a new flag BTRFS_DEV_STATE_READ_OPTIMISED is set.
>
> I'd say it should be called PREFERRED, and the format specifier could
> add ":" between devid and the numbers, like "devid:1,2,3", we'll
> probably want more types in the future.
>
> This is the first whole-filesystem property so we can't follow a naming
> scheme, so we'll have to decide if we go with flat or hierarchical
> naming with more generic categories like policy.mirror.read and similar.
I'll have to go through the past discussions again, there was some
feedback regarding this I did not take into account.
next prev parent reply other threads:[~2019-07-23 15:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 8:33 [PATCH 0/3 RESEND Rebased] readmirror feature Anand Jain
2019-06-26 8:34 ` [PATCH 1/3 RESEND Rebased] btrfs: add inode pointer to prop_handler::validate() Anand Jain
2019-06-26 8:34 ` [PATCH 2/3 RESEND Rebased] btrfs: add readmirror property framework Anand Jain
2019-07-23 14:57 ` David Sterba
2019-07-24 2:42 ` Anand Jain
2019-06-26 8:34 ` [PATCH 3/3 RESEND Rebased] btrfs: add readmirror devid property Anand Jain
2019-07-23 14:55 ` David Sterba
2019-07-23 15:25 ` David Sterba [this message]
2019-06-26 8:37 ` [PATCH 1/2 RESEND Rebased] btrfs-progs: add helper to create xattr name Anand Jain
2019-06-26 8:37 ` [PATCH 2/2 RESEND Rebased] btrfs-progs: add readmirror policy Anand Jain
2019-07-23 13:53 ` David Sterba
2019-07-24 3:11 ` Anand Jain
2019-07-23 13:55 ` David Sterba
2019-07-02 8:09 ` [PATCH 0/3 RESEND Rebased] readmirror feature Anand Jain
2019-07-24 0:20 ` Qu Wenruo
2019-07-24 2:26 ` Anand Jain
2019-07-24 3:05 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723152509.GG2868@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).