From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4D89C7618B for ; Thu, 25 Jul 2019 14:18:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84B4B22CBB for ; Thu, 25 Jul 2019 14:18:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728393AbfGYOSk (ORCPT ); Thu, 25 Jul 2019 10:18:40 -0400 Received: from mx2.suse.de ([195.135.220.15]:45628 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728034AbfGYOSj (ORCPT ); Thu, 25 Jul 2019 10:18:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 36649AE56; Thu, 25 Jul 2019 14:18:38 +0000 (UTC) Date: Thu, 25 Jul 2019 16:18:37 +0200 From: Johannes Thumshirn To: Qu Wenruo Cc: David Sterba , Linux BTRFS Mailinglist Subject: Re: [RFC PATCH 3/4] btrfs: use xxhash64 for checksumming Message-ID: <20190725141837.GA3936@x250.microfocus.com> References: <4ac3332af1fa5ba7ecb92181329151382b800f3d.1564046812.git.jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jul 25, 2019 at 08:02:12PM +0800, Qu Wenruo wrote: > > > On 2019/7/25 下午5:33, Johannes Thumshirn wrote: > > Signed-off-by: Johannes Thumshirn > > --- > > fs/btrfs/Kconfig | 1 + > > fs/btrfs/ctree.h | 1 + > > fs/btrfs/disk-io.c | 1 + > > fs/btrfs/super.c | 1 + > > include/uapi/linux/btrfs_tree.h | 1 + > > 5 files changed, 5 insertions(+) > > > > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig > > index 38651fae7f21..6d5a01c57da3 100644 > > --- a/fs/btrfs/Kconfig > > +++ b/fs/btrfs/Kconfig > > @@ -5,6 +5,7 @@ config BTRFS_FS > > select CRYPTO > > select CRYPTO_CRC32C > > select LIBCRC32C > > + select CRYPTO_XXHASH > > Just an off topic idea, can we make such CRYPTO_* support configurable? > E.g. make something like CONFIG_BTRFS_CRYPTO_XXHASH. > > Not sure if everyone would like to pull all hash algorithm. This is something I thought about as well, but I was afraid of people shooting themselves in the foot if they forget to switch them on and mkfs with the wrong option. Not sure what's the better way here? Dave? -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850