From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC762C3A59B for ; Mon, 19 Aug 2019 09:15:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9557F2184D for ; Mon, 19 Aug 2019 09:15:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727380AbfHSJPs (ORCPT ); Mon, 19 Aug 2019 05:15:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:57636 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726661AbfHSJPs (ORCPT ); Mon, 19 Aug 2019 05:15:48 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A0221AEFD for ; Mon, 19 Aug 2019 09:15:47 +0000 (UTC) Date: Mon, 19 Aug 2019 11:15:47 +0200 From: Johannes Thumshirn To: Nikolay Borisov Cc: David Sterba , Linux BTRFS Mailinglist Subject: Re: [RFC PATCH 4/4] btrfs: sysfs: export supported checksums Message-ID: <20190819091547.GC8571@x250> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Aug 12, 2019 at 12:19:13PM +0300, Nikolay Borisov wrote: > > +static struct btrfs_feature_attr btrfs_attr_features_checksums_name = { > > + .kobj_attr = __INIT_KOBJ_ATTR(checksums, S_IRUGO, > > + btrfs_checksums_show, > > + btrfs_checksums_store), > > Since we won't ever support writing to this sysfs just kill > btrfs_checksums_store and simply pass NULL as the last argument to > INIT_KOBJ_ATTR. > Yup will do. -- Johannes Thumshirn SUSE Labs Filesystems jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850