Re: [PATCH 4/5] btrfs: refactor priority_reclaim_metadata_space

[David Sterba <dsterba@suse.cz>]

On Thu, Aug 01, 2019 at 06:19:36PM -0400, Josef Bacik wrote:
> With the eviction flushing stuff we'll want to allow for different
> states, but still work basically the same way that
> priority_reclaim_metadata_space works currently.  Refactor this to take
> the flushing states and size as an argument so we can use the same logic
> for limit flushing and eviction flushing.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  fs/btrfs/space-info.c | 17 +++++++++++------
>  1 file changed, 11 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
> index 71749b355136..03556e411b11 100644
> --- a/fs/btrfs/space-info.c
> +++ b/fs/btrfs/space-info.c
> @@ -868,9 +868,12 @@ static const enum btrfs_flush_state priority_flush_states[] = {
>  	ALLOC_CHUNK,
>  };
>  
> -static void priority_reclaim_metadata_space(struct btrfs_fs_info *fs_info,
> -					    struct btrfs_space_info *space_info,
> -					    struct reserve_ticket *ticket)
> +static void
> +priority_reclaim_metadata_space(struct btrfs_fs_info *fs_info,

Please note that the split type and function name is the reverse of the
coding style used in btrfs, I fix such things but please don't introduce
it in new patches namely when the original code is using the correct
style.