From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: dev stats item key conversion per cpu type is not needed
Date: Wed, 21 Aug 2019 15:51:47 +0200 [thread overview]
Message-ID: <20190821135146.GD18575@twin.jikos.cz> (raw)
In-Reply-To: <20190821092634.6778-2-anand.jain@oracle.com>
On Wed, Aug 21, 2019 at 05:26:33PM +0800, Anand Jain wrote:
> %found_key is not used, drop it.
Patches that remove dead/unused code should say why, eg. in this case
the variable hasn't been used since the beginning, but in other cases it
may point to code that needs closer attention.
next prev parent reply other threads:[~2019-08-21 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 9:26 [PATCH 1/3] btrfs: dev stat drop useless goto Anand Jain
2019-08-21 9:26 ` [PATCH 2/3] btrfs: dev stats item key conversion per cpu type is not needed Anand Jain
2019-08-21 13:51 ` David Sterba [this message]
2019-08-21 9:26 ` [PATCH 3/3] btrfs: clean search for device item in finish sprout Anand Jain
2019-08-21 13:54 ` David Sterba
2019-08-21 14:01 ` David Sterba
2019-08-21 14:02 ` [PATCH 1/3] btrfs: dev stat drop useless goto David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821135146.GD18575@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).