From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF939C3A59E for ; Wed, 21 Aug 2019 14:07:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CACB72339E for ; Wed, 21 Aug 2019 14:07:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729133AbfHUOHf (ORCPT ); Wed, 21 Aug 2019 10:07:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:59014 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727949AbfHUOHf (ORCPT ); Wed, 21 Aug 2019 10:07:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 75603AFD4; Wed, 21 Aug 2019 14:07:34 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 7A345DA7DB; Wed, 21 Aug 2019 16:07:59 +0200 (CEST) Date: Wed, 21 Aug 2019 16:07:58 +0200 From: David Sterba To: Nikolay Borisov Cc: Josef Bacik , kernel-team@fb.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 8/8] btrfs: remove orig_bytes from reserve_ticket Message-ID: <20190821140758.GH18575@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , Josef Bacik , kernel-team@fb.com, linux-btrfs@vger.kernel.org References: <20190816141952.19369-1-josef@toxicpanda.com> <20190816141952.19369-9-josef@toxicpanda.com> <7a26af57-a7a5-310f-6568-a274c28312a5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a26af57-a7a5-310f-6568-a274c28312a5@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 20, 2019 at 11:28:54AM +0300, Nikolay Borisov wrote: > > > On 16.08.19 г. 17:19 ч., Josef Bacik wrote: > > Now that we do not do partial filling of tickets simply remove > > orig_bytes, it is no longer needed. > > > > Signed-off-by: Josef Bacik > > Reviewed-by: Nikolay Borisov > > nit: I think this patch should follow directly after 'btrfs: rework > wake_all_tickets' or it could even be squashed in it. But let's see how > David will prefer it. The patch does not apply on current misc-next + the ticket series, but looking at the patches as they are now, the separation seems ok. 8 depends on 7 so the unused code cleanup is not in the fix.