From: Naohiro Aota <naohiro.aota@wdc.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.com>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
Nikolay Borisov <nborisov@suse.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Matias Bjorling <Matias.Bjorling@wdc.com>,
Hannes Reinecke <hare@suse.com>,
Anand Jain <anand.jain@oracle.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 02/27] btrfs: Get zone information of zoned block devices
Date: Mon, 26 Aug 2019 15:29:10 +0900 [thread overview]
Message-ID: <20190826062910.7kbbreqmpl4bri6v@naota.dhcp.fujisawa.hgst.com> (raw)
In-Reply-To: <ae5e9761-7191-20fa-02c5-abe8b81d278c@suse.de>
On Fri, Aug 23, 2019 at 01:57:33PM +0200, Johannes Thumshirn wrote:
>On 23/08/2019 12:10, Naohiro Aota wrote:
>[...]
>> +int btrfs_get_dev_zone_info(struct btrfs_device *device)
>> +{
>> + struct btrfs_zoned_device_info *zone_info = NULL;
>> + struct block_device *bdev = device->bdev;
>> + sector_t nr_sectors = bdev->bd_part->nr_sects;
>> + sector_t sector = 0;
>> + struct blk_zone *zones = NULL;
>> + unsigned int i, nreported = 0, nr_zones;
>> + unsigned int zone_sectors;
>> + int ret;
>> +
>> + if (!bdev_is_zoned(bdev))
>> + return 0;
>> +
>> + zone_info = kzalloc(sizeof(*zone_info), GFP_KERNEL);
>> + if (!zone_info)
>> + return -ENOMEM;
>> +
>> + zone_sectors = bdev_zone_sectors(bdev);
>> + ASSERT(is_power_of_2(zone_sectors));
>> + zone_info->zone_size = (u64)zone_sectors << SECTOR_SHIFT;
>> + zone_info->zone_size_shift = ilog2(zone_info->zone_size);
>> + zone_info->nr_zones = nr_sectors >> ilog2(bdev_zone_sectors(bdev));
>> + if (nr_sectors & (bdev_zone_sectors(bdev) - 1))
>> + zone_info->nr_zones++;
>> +
>> + zone_info->seq_zones = kcalloc(BITS_TO_LONGS(zone_info->nr_zones),
>> + sizeof(*zone_info->seq_zones),
>> + GFP_KERNEL);
>> + if (!zone_info->seq_zones) {
>> + ret = -ENOMEM;
>> + goto out;
>> + }
>> +
>> + zone_info->empty_zones = kcalloc(BITS_TO_LONGS(zone_info->nr_zones),
>> + sizeof(*zone_info->empty_zones),
>> + GFP_KERNEL);
>> + if (!zone_info->empty_zones) {
>> + ret = -ENOMEM;
>> + goto out;
>> + }
>> +
>> +
>> + zones = kcalloc(BTRFS_REPORT_NR_ZONES,
>> + sizeof(struct blk_zone), GFP_KERNEL);
>> + if (!zones)
>> + return -ENOMEM;
>
>Won't this will leak zone_info, zone_info->seq_zones and
>zone_info->empty_zones.
Ah, yes. I'll fix that using the suggested style below.
Thanks
>
>[...]
>
>> +out:
>> + kfree(zones);
>> +
>> + if (ret) {
>> + kfree(zone_info->seq_zones);
>> + kfree(zone_info->empty_zones);
>> + kfree(zone_info);
>> + }
>
>Which is why I think it would be more clear to have:
>free_zones:
> kfree(zones);
>free_zi_emp_zones:
> kfree(zone_info->empty_zones);
>free_zi_seq_zones:
> kfree(zone_info->seq_zones);
>free_zi:
> kfree(zone_info);
>
>
>
>--
>Johannes Thumshirn SUSE Labs Filesystems
>jthumshirn@suse.de +49 911 74053 689
>SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
>GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
>HRB 21284 (AG Nürnberg)
>Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2019-08-26 6:29 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 10:10 [PATCH v4 00/27] btrfs zoned block device support Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 01/27] btrfs: introduce HMZONED feature flag Naohiro Aota
2019-08-23 11:45 ` Johannes Thumshirn
2019-08-23 10:10 ` [PATCH v4 02/27] btrfs: Get zone information of zoned block devices Naohiro Aota
2019-08-23 11:57 ` Johannes Thumshirn
2019-08-26 6:29 ` Naohiro Aota [this message]
2019-08-24 9:22 ` kbuild test robot
2019-08-24 10:49 ` kbuild test robot
2019-08-23 10:10 ` [PATCH v4 03/27] btrfs: Check and enable HMZONED mode Naohiro Aota
2019-08-23 12:07 ` Johannes Thumshirn
2019-08-26 8:38 ` Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 04/27] btrfs: disallow RAID5/6 in " Naohiro Aota
2019-08-23 12:09 ` Johannes Thumshirn
2019-08-23 10:10 ` [PATCH v4 05/27] btrfs: disallow space_cache " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 06/27] btrfs: disallow NODATACOW " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 07/27] btrfs: disable tree-log " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 08/27] btrfs: disable fallocate " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 09/27] btrfs: align device extent allocation to zone boundary Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 10/27] btrfs: do sequential extent allocation in HMZONED mode Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 11/27] btrfs: make unmirroed BGs readonly only if we have at least one writable BG Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 12/27] btrfs: ensure metadata space available on/after degraded mount in HMZONED Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 13/27] btrfs: reset zones of unused block groups Naohiro Aota
2019-08-24 11:32 ` kbuild test robot
2019-08-25 4:56 ` kbuild test robot
2019-08-23 10:10 ` [PATCH v4 14/27] btrfs: limit super block locations in HMZONED mode Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 15/27] btrfs: redirty released extent buffers in sequential BGs Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 16/27] btrfs: serialize data allocation and submit IOs Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 17/27] btrfs: implement atomic compressed IO submission Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 18/27] btrfs: support direct write IO in HMZONED Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 19/27] btrfs: serialize meta IOs on HMZONED mode Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 20/27] btrfs: wait existing extents before truncating Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 21/27] btrfs: avoid async checksum/submit on HMZONED mode Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 22/27] btrfs: disallow mixed-bg in " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 23/27] btrfs: disallow inode_cache " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 24/27] btrfs: support dev-replace " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 25/27] btrfs: enable relocation " Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 26/27] btrfs: relocate block group to repair IO failure in HMZONED Naohiro Aota
2019-08-23 10:10 ` [PATCH v4 27/27] btrfs: enable to mount HMZONED incompat flag Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826062910.7kbbreqmpl4bri6v@naota.dhcp.fujisawa.hgst.com \
--to=naohiro.aota@wdc.com \
--cc=Matias.Bjorling@wdc.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=damien.lemoal@wdc.com \
--cc=dsterba@suse.com \
--cc=hare@suse.com \
--cc=josef@toxicpanda.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).