From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D293C43140 for ; Thu, 5 Sep 2019 16:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20186207E0 for ; Thu, 5 Sep 2019 16:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733054AbfIEQ1Y (ORCPT ); Thu, 5 Sep 2019 12:27:24 -0400 Received: from verein.lst.de ([213.95.11.211]:50124 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729136AbfIEQ1Y (ORCPT ); Thu, 5 Sep 2019 12:27:24 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 905E368B20; Thu, 5 Sep 2019 18:27:21 +0200 (CEST) Date: Thu, 5 Sep 2019 18:27:21 +0200 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, darrick.wong@oracle.com, hch@lst.de, linux-xfs@vger.kernel.org, Goldwyn Rodrigues Subject: Re: [PATCH 11/15] iomap: use a function pointer for dio submits Message-ID: <20190905162721.GC22450@lst.de> References: <20190905150650.21089-1-rgoldwyn@suse.de> <20190905150650.21089-12-rgoldwyn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190905150650.21089-12-rgoldwyn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org > + if (dio->dops && dio->dops->submit_io) { > + dio->dops->submit_io(bio, file_inode(dio->iocb->ki_filp), > + pos); pos would still fit on the previously line as-is. > + dio->submit.cookie = BLK_QC_T_NONE; But I think you should return the cookie from the submit function for completeness, even if btrfs would currently always return BLK_QC_T_NONE.