From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Ritesh Harjani <riteshh@linux.ibm.com>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.de>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-btrfs@vger.kernel.org, hch@infradead.org,
andres@anarazel.de, david@fromorbit.com,
linux-f2fs-devel@lists.sourceforge.net,
Goldwyn Rodrigues <rgoldwyn@suse.com>,
aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH 2/3] ext4: fix inode rwsem regression
Date: Thu, 12 Sep 2019 19:26:14 +1000 [thread overview]
Message-ID: <20190912092614.GB9747@bobrowski> (raw)
In-Reply-To: <20190912085236.7C51642042@d06av24.portsmouth.uk.ibm.com>
On Thu, Sep 12, 2019 at 02:22:35PM +0530, Ritesh Harjani wrote:
> cc'd Matthew as well.
>
> > This is similar to 942491c9e6d6 ("xfs: fix AIM7 regression")
> > Apparently our current rwsem code doesn't like doing the trylock, then
> > lock for real scheme. So change our read/write methods to just do the
> > trylock for the RWF_NOWAIT case.
> >
> > Fixes: 728fbc0e10b7 ("ext4: nowait aio support")
> > Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> This patch will conflict with recent iomap patch series.
> So if this is getting queued up before, so iomap patch series will
> need to rebase and factor these changes in the new APIs.
Noted. I've been keeping my eye on this thread, so I'm aware of this.
--<M>--
next prev parent reply other threads:[~2019-09-12 9:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190910223327.mnegfoggopwqqy33@alap3.anarazel.de>
[not found] ` <20190911040420.GB27547@dread.disaster.area>
2019-09-11 9:39 ` Odd locking pattern introduced as part of "nowait aio support" Andres Freund
2019-09-11 10:19 ` Christoph Hellwig
2019-09-11 10:31 ` Ritesh Harjani
2019-09-11 10:55 ` Goldwyn Rodrigues
2019-09-11 16:45 ` Fix inode sem regression for nowait Goldwyn Rodrigues
2019-09-11 16:45 ` [PATCH 1/3] btrfs: fix inode rwsem regression Goldwyn Rodrigues
2019-09-11 17:21 ` David Sterba
2019-09-11 16:45 ` [PATCH 2/3] ext4: " Goldwyn Rodrigues
2019-09-12 8:52 ` Ritesh Harjani
2019-09-12 9:26 ` Matthew Bobrowski [this message]
2019-09-23 10:10 ` Jan Kara
2019-09-23 13:18 ` Theodore Y. Ts'o
2019-09-11 16:45 ` [PATCH 3/3] f2fs: " Goldwyn Rodrigues
2019-09-12 6:17 ` Chao Yu
2019-09-13 19:46 ` Jaegeuk Kim
2019-09-16 1:16 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190912092614.GB9747@bobrowski \
--to=mbobrowski@mbobrowski.org \
--cc=andres@anarazel.de \
--cc=aneesh.kumar@linux.ibm.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).